1847280 - Export more MathML WPT tests

Status: RESOLVED FIXED

(Core :: MathML, task)

Comment 1

[Frédéric Wang Nélar]

Attachment: Bug 1847280 - Export more MathML reftests to WPT. r=emilio

• link-1: This is testing <mtext href> link render specially. href is
  not in the current MathML Core spec.

• negative-mspace-1: This is testing negative values for mspace@width but
  MathML Core just currently maps it to the width property which does not
  accept negative values.

• mathml-type-supported: This verify application/mathml+xml is recognized
  by the browser and will open a page with such a MIME type. Such a
  behavior is not specified in MathML Core.

• web-platform/tests/mathml/presentation-markup/mrow/mphantom-001.html:
  Copy and tweak from existing merror-001.html to check style and size
  of the <mphantom> element.

• menclose-in-mphantom: Remove since that's now covered by the new
  mphantom-001.html plus existing visibility-004.tentative.html

• mphantom-1: Remove since that's covered by the new mphantom-001.html
  plus exisiting visibility-00{1,2,3}.html

• mphantom-2: Remove since that's covered by the new mphantom-001.html
  and other more advanced tests for mrow-like elements.

• non-spacing-accent-1: This is testing a valid MathML Core behavior
  (assuming system fonts can render U+0302 COMBINING CIRCUMFLEX ACCENT)
  so upstream it to WPT.

• overbar-width-1, underbar-width-1: Ditto, and there is no need to
  assume system fonts have the the overbar/underbar char since there is
  a hiding div.

• stretchy-underbar-1: This test assumes that the underbar stretches
  but U+332 is not stretchy by default in MathML Core's operator
  dictionary, so add an explicit attribute. Probably the original test
  makes more assumption (system font, etc) so don't touch it too much.
  Even if the operator does not stretch, it would still pass anyway.

Comment 2

[Frédéric Wang Nélar]

I tried converting layout/reftests/radicalbar*.html to WPT, replacing
reftest-zoom with SpecialPowers.setFullZoom. However, that didn't work
because we cannot reset the zoom level after the screenshot and that
affects subsequent tests. I'm now considering converting to a
testharness instead relying on SpecialPowers.snapshotWindowWithOptions
to check if the bar is visible. That may also make the test more
readable.

I also noticed that reftest-zoom=".2" is actually clamped to
zoom.minPercent so the radicalbar-*d.html are the same as
radicalbar-*c.html (see attachment). That's not the case with
SpecialPowers.setFullZoom, and I realized that with the patch
bug 1011020 is actually still present for a 20% zoom level.
I also did verify that reverting the changes to
nsDisplayMathMLBar::Paint make radicalbar-*c.html fail. Maybe
it makes sense to restrict to values not less than zoom.minPercent
instead.

Comment 3

[Frédéric Wang Nélar]

Attachment: 0001-Experimental-WPT-for-bug-1011020.patch

The buffer returned by SpecialPowers.snapshotWindowWithOptions does not seem to be affected by zoom level so that does not allow to reproduce bug 1011020. I'm attaching my attempt. I guess we'll have to keep radicalbar* as non-WPT reftests for now.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2827b7f32d70
Export more MathML reftests to WPT. r=emilio

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41791 for changes under testing/web-platform/tests

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for failures on underbar-width-1.xhtml

Backout link: https://hg.mozilla.org/integration/autoland/rev/8db6d9da9c8cd32a1f49758f7c758dbe9e51d570
Log link: https://treeherder.mozilla.org/logviewer?job_id=427890899&repo=autoland&lineNumber=16887

Please also check this failure: https://treeherder.mozilla.org/logviewer?job_id=427890086&repo=autoland&lineNumber=9217

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:fredw, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 9

[Frédéric Wang Nélar]

(In reply to Narcis Beleuzu [:NarcisB] from comment #6)

Backed out for failures on underbar-width-1.xhtml

Backout link: https://hg.mozilla.org/integration/autoland/rev/8db6d9da9c8cd32a1f49758f7c758dbe9e51d570
Log link: https://treeherder.mozilla.org/logviewer?job_id=427890899&repo=autoland&lineNumber=16887

OK let's not export underbar-width-1 (and the similar overbar-width-1) for now. It seems result is dependent on system fonts at the end...

Please also check this failure: https://treeherder.mozilla.org/logviewer?job_id=427890086&repo=autoland&lineNumber=9217

This one was based on merror-001.html but I forgot to tweak it so a border is not expected.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/350b696788a1
Export more MathML reftests to WPT. r=emilio

Comment 11

[Natalia Csoregi [:nataliaCs]]

Backed out as per request in Bug 1856568

• backout: https://hg.mozilla.org/integration/autoland/rev/bd7f6c4bab1e6cfb3afcbb63b2f0cbd94d8c86a8
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=350b696788a174ceeba0e05ac3ef2be7ddd7c5af
• failure log: https://treeherder.mozilla.org/logviewer?job_id=431119185&repo=autoland&lineNumber=5672

Comment 12

[Frédéric Wang Nélar]

(In reply to Frédéric Wang (:fredw) from comment #9)

OK let's not export underbar-width-1 (and the similar overbar-width-1) for now. It seems result is dependent on system fonts at the end...

The patch landed was still incorrectly removing the files. Will fix it.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f003c74ca9f9
Export more MathML reftests to WPT. r=emilio

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f003c74ca9f9

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot