Closed Bug 1847282 Opened 6 months ago Closed 5 months ago

Change the default setting for pull-to-refresh to disabled

Categories

(Fenix :: Browser Engine, task, P2)

Product:
Fenix
Component:
Browser Engine
Platform:
All
Android
Type:
task

Tracking

(firefox116 verified, firefox117 verified, firefox118 verified)

Status:
VERIFIED FIXED
Milestone:
118 Branch
Tracking Flags:
Tracking Status
firefox116 --- verified
firefox117 --- verified
firefox118 --- verified

People

(Reporter: jonalmeida, Assigned: jonalmeida)

References

(Blocks 1 open bug)

Details

(Whiteboard: [geckoview:m118])

Attachments

(3 files, 1 obsolete file)

[mozilla-mobile/firefox-android] Bug 1847282 - Change the default for pull-to-refresh to disabled (#3234)
59 bytes, text/x-github-pull-request
Details | Review
[mozilla-mobile/firefox-android] Bug 1847282 - Change the default for pull-to-refresh to disabled (backport #3234) (#3236)
59 bytes, text/x-github-pull-request
diannaS
: approval-mozilla-release+
Details | Review
[mozilla-mobile/firefox-android] Bug 1847282 - Change the default for pull-to-refresh to disabled (backport #3234) (#3239)
59 bytes, text/x-github-pull-request
diannaS
: approval-mozilla-beta+
Details | Review

Given the number of bugs we are receiving for pull-to-refresh from users, we should change the default to be disabled.

For users who are not aware of the feature, we have received app reviews and webcompat bugs which affect the product quality.

We do not need to unship this feature, as users that choose to enable it with the buggy behaviour are fine with it.

And when will all the pull-to-refresh errors be fully resolved?

Flags: needinfo?(jonalmeida942)

We're working through the bugs to make the experience better. It's hard to say.

Flags: needinfo?(jonalmeida942)
Assignee: nobody → jonalmeida942
Whiteboard: [geckoview:m118]
Severity: -- → N/A
status-firefox116: --- → affected
status-firefox117: --- → affected
status-firefox118: --- → affected
Priority: -- → P2

Authored by https://github.com/jonalmeida
https://github.com/mozilla-mobile/firefox-android/commit/ef7ba0668870541a02f7db63d4a689a5f3eb252a
[main] Bug 1847282 - Change the default for pull-to-refresh to disabled

Status: NEW → RESOLVED
Closed: 5 months ago
status-firefox118: affected → fixed
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
Comment on attachment 9348672 [details] [review]
[mozilla-mobile/firefox-android] Bug 1847282 - Change the default for pull-to-refresh to disabled (backport #3234) (#3237)

This uplift patch was made in error.
Attachment #9348672 - Attachment is obsolete: true

Comment on attachment 9348671 [details] [review]
[mozilla-mobile/firefox-android] Bug 1847282 - Change the default for pull-to-refresh to disabled (backport #3234) (#3236)

Beta/Release Uplift Approval Request

  • User impact if declined: Users will continue to experience buggy behaviour from pull-to-refresh that we have already identified and are working to resolve.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. Download a fresh version of Firefox for Android.
  1. Open Settings > Customize > Gestures.
  2. Verify that 'Pull to refresh' is disabled by default.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This changes the default value for a pref to disabled which will improve scrolling and gestures.
  • String changes made/needed: No
  • Is Android affected?: Yes
Attachment #9348671 - Flags: approval-mozilla-release?

Comment on attachment 9348674 [details] [review]
[mozilla-mobile/firefox-android] Bug 1847282 - Change the default for pull-to-refresh to disabled (backport #3234) (#3239)

Beta/Release Uplift Approval Request

  • User impact if declined: Users will continue to experience buggy behaviour from pull-to-refresh that we have already identified and are working to resolve.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. Download a fresh version of Firefox for Android.
  1. Open Settings > Customize > Gestures.
  2. Verify that 'Pull to refresh' is disabled by default.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This changes the default value for a pref to disabled which will improve scrolling and gestures.
  • String changes made/needed: No
  • Is Android affected?: Yes
Attachment #9348674 - Flags: approval-mozilla-beta?

Diana, will this make it in time for the 116 dot release? Apologies in advance, if this causes more work!

Flags: needinfo?(dsmith)
Comment on attachment 9348674 [details] [review]
[mozilla-mobile/firefox-android] Bug 1847282 - Change the default for pull-to-refresh to disabled (backport #3234) (#3239)

Approved for Mobile 117.0b7
Attachment #9348674 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment on attachment 9348671 [details] [review]
[mozilla-mobile/firefox-android] Bug 1847282 - Change the default for pull-to-refresh to disabled (backport #3234) (#3236)

Approved for Mobile 116.3.0

Yes it will make it in time. Since it is jut disabling this, ill merge it now.
Flags: needinfo?(dsmith)
Attachment #9348671 - Flags: approval-mozilla-release? → approval-mozilla-release+

Verified as fixed on Beta 117.0b7 and RC 116.3.0, where the "Pull to refresh" toggle is OFF by default.
Tested with:

  • Huawei MediaPad M2 (Android 5.1.1)
  • Sony Xperia (Android 6.0.1)
  • HTC 10 (Android 8)
  • Google Pixel 7 (Android 14)

The "Pull to refresh" toggle remains ON by default in Nightly 118.0a1 from 08/14.

status-firefox116: fixed → verified
status-firefox117: fixed → verified
Flags: needinfo?(jonalmeida942)
Status: RESOLVED → VERIFIED
status-firefox118: fixed → verified
Flags: qe-verify+
Flags: needinfo?(jonalmeida942)
You need to log in before you can comment on or make changes to this bug.