1847842 - Prevent TreeView widget scrolling to a row that doesn't exist

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect, P2)

Description

[Geoff Lankow (:darktrojan)]

If the selected index of a TreeView is set to -1 (no selection) it scrolls to the top, because -1 is below zero and it can't scroll any further. Removing the selection by any means should not scroll the view. We should avoid calling scrollToIndex in this situation, and even if we do it should report the bad index and refuse to do anything.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1847842 - Prevent TreeView widget scrolling to a row that doesn't exist. r=#thunderbird-front-end-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b0724a07f90f
Prevent TreeView widget scrolling to a row that doesn't exist. r=aleca

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9348019 [details]
Bug 1847842 - Prevent TreeView widget scrolling to a row that doesn't exist. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: in some circumstances the message list can scroll to the top for no apparent reason
Testing completed (on c-c, etc.): landed 5 days ago
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9348019 [details]
Bug 1847842 - Prevent TreeView widget scrolling to a row that doesn't exist. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 117.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/10b0b46cacb5

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9348019 [details]
Bug 1847842 - Prevent TreeView widget scrolling to a row that doesn't exist. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for esr115

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 115.2.0:
https://hg.mozilla.org/releases/comm-esr115/rev/75c93433f569