1847898 - mach vendor for fdlibm doesn't work on git

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tooru Fujisawa [:arai]]

Run the following on git checkout:

./mach vendor modules/fdlibm/moz.yaml -r bd5e624a861433dee76fe00a8acedc9564425332 -f --patch-mode=none

got the output:

Latest commit is bd5e624a861433dee76fe00a8acedc9564425332 from 2022-12-13T19:21:13Z
...
Upstream bd5e624a861433dee76fe00a8acedc9564425332 hasn't modified files locally.

it's due to spurious_check uses staged mode to list files, which is empty on git.

https://searchfox.org/mozilla-central/rev/dc8348b3730c0d29dafd01c653d9151eaa9bc30f/python/mozbuild/mozbuild/vendor/vendor_manifest.py#592-598

def spurious_check(self, revision, ignore_modified):
    changed_files = set(
        [
            os.path.abspath(f)
            for f in self.repository.get_changed_files(mode="staged")
        ]
    )

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1847898 - Part 1: Move individiual update's fetch step into separate function. r?tjr!

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1847898 - Part 2: Merge process_regular and process_individual implementation. r?tjr!

Depends on D185792

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a30a668a87c
Part 1: Move individiual update's fetch step into separate function. r=tjr
https://hg.mozilla.org/integration/autoland/rev/ca6eb6e813a9
Part 2: Merge process_regular and process_individual implementation. r=tjr

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1a30a668a87c
https://hg.mozilla.org/mozilla-central/rev/ca6eb6e813a9