1847901 - Firefox 116 "<site> is now full screen" keeps randomly showing up on alt-tab.

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[yuio_bugan]

Attachment: Screenshot 2023-08-09 170614.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0

Steps to reproduce:

1. Open Firefox
2. Go to about:config
3. Set full-screen-api.warning.timeout to '0'
4. Go to youtube.com
5. Open any youtube video
6. Watch said video in full screen
7. Have another application running in full screen as well (I tested with a game)
8. Repeat alt-tabbing
9. Repeat step 6-8 until

Actual results:

"youtube.com is now full screen" message box randomly shows up from the top

Expected results:

With full-screen-api.warning.timeout set to '0', on previous versions of Firefox, the message box never shows up anymore.

Comment 1

[yuio_bugan]

Forgot to mention, the message box never disappears after this happens unless I toggle in and out of full screen again.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics: WebRender' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Almost surely a regression from bug 1821884... Maybe that didn't deal well with the timeout=0 case?

Comment 4

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Bug 1847901 - Should not show fullscreen warning if the user has disabled it explicitly; r?Gijs

Comment 5

[Nikos Chantziaras]

Same issue here. I had completely forgotten that I've set full-screen-api.warning.timeout to 0. I now changed it to 1 instead and that fixed the issue here.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c162e53019ef
Should not show fullscreen warning if the user has disabled it explicitly; r=Gijs

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c162e53019ef

Comment 11

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Comment on attachment 9348522 [details]
Bug 1847901 - Should not show fullscreen warning if the user has disabled it explicitly; r?Gijs

Beta/Release Uplift Approval Request

• User impact if declined: The fullscreen notification is persistently shown to the user, even if they have explicitly disabled it.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change only impacts the scenario where full-screen-api.warning.timeout is set to 0 to disable fullscreen notification, which users would need to configure manually in about:config.
• String changes made/needed: None
• Is Android affected?: No

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is a regression of bug 1821884.
• User impact if declined: The fullscreen notification is persistently shown to the user, even if they have explicitly disabled it.
• Fix Landed on Version: 118
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change only impacts the scenario where full-screen-api.warning.timeout is set to 0 to disable fullscreen notification, which users would need to configure manually in about:config.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9348522 [details]
Bug 1847901 - Should not show fullscreen warning if the user has disabled it explicitly; r?Gijs

Approved for 117.0b8.

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/5e3bb6b93f00

Comment 14

[Dianna Smith [:diannaS]]

Comment on attachment 9348522 [details]
Bug 1847901 - Should not show fullscreen warning if the user has disabled it explicitly; r?Gijs

Approved for 116.0.3 dot release

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/57e80ba4372f

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/7b8696b56bba

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9348522 [details]
Bug 1847901 - Should not show fullscreen warning if the user has disabled it explicitly; r?Gijs

Approved for 115.2esr.

Comment 18

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/b3155335c748

Comment 19

[Peter Magyari (Desktop QA)]

The issue is reproducible on Firefox Nightly 118.0a1 (20230814095629) and Firefox 116.0.2 (20230805021307).

I have verified the fix on Windows 10 and MacOS 11.6 using the following Firefox versions:

• 118.0a1 (20230815091726)
• 117.0b8 (20230815180041)
• 116.0.3 (20230815164403)
• 115.2.0esr (20230815193934)

I'm setting the flags accordingly.