1847979 - Use CSS nesting for .urlbarView-body-inner, .urlbarView-results, .urlbarView-row, .urlbarView-row-inner, and .urlbarView-no-wrap rules

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1847975 +++

https://searchfox.org/mozilla-central/rev/dc8348b3730c0d29dafd01c653d9151eaa9bc30f/browser/themes/shared/urlbarView.css#107-136,138-149 can be simplified using CSS nesting.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1847979 - Use CSS nesting for .urlbarView-body-inner, .urlbarView-results, .urlbarView-row, .urlbarView-row-inner, and .urlbarView-no-wrap rules. r=adw

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dab3c6a6f956
Use CSS nesting for .urlbarView-body-inner, .urlbarView-results, .urlbarView-row, .urlbarView-row-inner, and .urlbarView-no-wrap rules. r=adw

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out for causing bc failures on browser_glean_telemetry_abandonment_tips.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&fromchange=40053facf08c6ea9bc6a6f5ae223a6faa89ebc08&test_paths=browser%2Fcomponents%2Furlbar%2Ftests%2Fengagementtelemetry%2Fbrowser&tochange=53bdaffc44ebefe114cd14d09afe22d1c93f0116&selectedTaskRun=QZ8Z8evaSaOmdj8eK_euxg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=428026682&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/53bdaffc44ebefe114cd14d09afe22d1c93f0116

Comment 4

[Dão Gottwald [:dao]]

(In reply to Cosmin Sabou [:CosminS] from comment #3)

Backed out for causing bc failures on browser_glean_telemetry_abandonment_tips.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&fromchange=40053facf08c6ea9bc6a6f5ae223a6faa89ebc08&test_paths=browser%2Fcomponents%2Furlbar%2Ftests%2Fengagementtelemetry%2Fbrowser&tochange=53bdaffc44ebefe114cd14d09afe22d1c93f0116&selectedTaskRun=QZ8Z8evaSaOmdj8eK_euxg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=428026682&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/53bdaffc44ebefe114cd14d09afe22d1c93f0116

I can't explain this, nor reproduce it locally or on try: https://treeherder.mozilla.org/jobs?repo=try&revision=845347d1088480fd8d2eae6a25734de107954f72
Gonna try to just reland this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64b9c8cb9525
Use CSS nesting for .urlbarView-body-inner, .urlbarView-results, .urlbarView-row, .urlbarView-row-inner, and .urlbarView-no-wrap rules. r=adw

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures on browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_abandonment_tips.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/0b5e41c09feac83d07ddde76efa750f74415bb86

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_abandonment_tips.js | Test timed out

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69c7e9b937f8
Use CSS nesting for .urlbarView-body-inner, .urlbarView-results, .urlbarView-row, .urlbarView-row-inner, and .urlbarView-no-wrap rules. r=adw

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/69c7e9b937f8