1871022 - Rich Entities suggestion icons are not horizontally aligned to the text

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: rich entities icon misalignment

Found in

• Fx122.0b1

Affected versions

• Fx122.0b1
• Fx123.0a1

Affected platforms

• Windows 10
• Ubuntu 20.04
• macOS

Steps to reproduce

1. Launch Firefox.
2. In the address bar, type something that will return rich results (e.g. carl).

Expected result

• Rich suggestions icons are correctly aligned with the text.

Actual result

• Rich suggestions icons are one pixel off from bottom alignment with the text.

Regression range

• Will look for a regression ASAP, but this looks like something specific to rich suggestions.

Additional notes

• Please note that not all rich suggestions are misaligned to their corresponding icons (see screenshot for more details).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:cbaica, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Mark Banner (:standard8)]

Dale, can you take a look at this? Is this a result of the images received from Google being different heights or do we have a layout issue?

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: Bug 1871022 - Ensure rows are evenly sized. r=adw

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be3fca116905
Ensure rows are evenly sized. r=adw,dao

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/be3fca116905

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:daleharvey, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Dale Harvey (:daleharvey)]

Yeh I would have done the same as Ryan here thanks, its a relatively minor bug, riding the trains seems fine

Comment 9

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: latest rich entities mis-alignment bug

Hello Dale,
I have re-tested this using the latest nightly and beta builds (126.0a1 and 125.0b1) and the issue still persists.
One thing that I've noticed and might be worth mentioning, is that the first rich entity entry (regardless of the position in the drop-down) is aligned.

Comment 10

[Chris Bellini (:cbellini)]

Would it be possible to open this as a new bug for 126?

Comment 11

[Cristian Baica [:cbaica], Release Desktop QA]

Closing this out as later fixes will be posted in 1887709.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

MOVED is for bugs that get moved to a different issue tracker.