1848253 - Firefox fails WPT css/css-grid/alignment/grid-align-baseline-001.html and -002, and grid-justify-baseline-* (with grid items doing first/last baseline alignment, using opposite-polarity writing modes)

Status: RESOLVED FIXED

(Core :: Layout: Grid, defect)

Description

[Daniel Holbert [:dholbert]]

We fail subtests in these two interop-2023-grid WPT tests:

https://wpt.fyi/results/css/css-grid/alignment/grid-align-baseline-001.html
https://wpt.fyi/results/css/css-grid/alignment/grid-align-baseline-002.html

This is the grid version of flexbox bug 1834663, essentially. We've got some grid items doing first baseline alignment and last baseline alignment, and the test is expecting those to match up (from opposite groups) if the writing modes have opposite-direction block flow.

Comment 1

[Daniel Holbert [:dholbert]]

I think this is also responsible for most or all of these:
https://wpt.fyi/results/css/css-grid/alignment/grid-justify-baseline-001.html
https://wpt.fyi/results/css/css-grid/alignment/grid-justify-baseline-002.html
https://wpt.fyi/results/css/css-grid/alignment/grid-justify-baseline-003.html
https://wpt.fyi/results/css/css-grid/alignment/grid-justify-baseline-004.html
https://wpt.fyi/results/css/css-grid/alignment/grid-justify-baseline-005.html

Comment 2

[Daniel Holbert [:dholbert]]

Probably also this one:
https://wpt.fyi/results/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-007.html

This one has some baseline-aligned vertical-lr and -rl grid items. When baseline-aligning, we're snapping them all to the right (block-start) side, but we should instead be aligning the bottom right ones (vertical-lr) to the opposite side, since their first-baseline alignment should put them in the left-side baseline-sharing group (the sharing group that corresponds to the side where their first baseline is)

Comment 3

[Daniel Holbert [:dholbert]]

Following up here: we now pass all of the tests that have been mentioned above (via Tiaan's fixes from bug 1878846 I think), except for some subtests in these ones:
https://wpt.fyi/results/css/css-grid/alignment/grid-justify-baseline-004.html?label=master&label=experimental&aligned
https://wpt.fyi/results/css/css-grid/alignment/grid-justify-baseline-005.html?label=experimental&label=master&aligned

...and this reftest where we seem to be off by 1px, which suggests that it might not be a "real" failure and may just be a rounding difference (possibly a version of bug 1808788):
https://wpt.fyi/results/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-007.html?label=experimental&label=master&aligned

We probably should re-triage the failures above and spin off new bugs for them, and close this one since the tests & root-issue discussed in comment 0 here have been fixed.

Comment 4

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #3)

Following up here: we now pass all of the tests that have been mentioned above (via Tiaan's fixes from bug 1878846 I think), except for some subtests in these ones:
https://wpt.fyi/results/css/css-grid/alignment/grid-justify-baseline-004.html?label=master&label=experimental&aligned
https://wpt.fyi/results/css/css-grid/alignment/grid-justify-baseline-005.html?label=experimental&label=master&aligned

I spun off bug 1902795 for these ones.

...and this reftest where we seem to be off by 1px, which suggests that it might not be a "real" failure and may just be a rounding difference (possibly a version of bug 1808788):
https://wpt.fyi/results/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-007.html?label=experimental&label=master&aligned

I spun off bug 1902793 for this one.

close this one since the tests & root-issue discussed in comment 0 here have been fixed.

--> Closing as FIXED by bug 1878846