1878846 - [css-grid] Baseline aligned items should join the correct sharing group according to writing mode

Status: RESOLVED FIXED

(Core :: Layout: Grid, defect, P2)

Description

[Tiaan Louw [:tlouw]]

https://drafts.csswg.org/css-align-3/#baseline-terms

The baseline alignment preferences of two boxes in a baseline-sharing group are compatible if they have:
- the same block flow direction and same baseline alignment preference
- opposite block flow direction and opposite baseline alignment preference

Comment 1

[Tiaan Louw [:tlouw]]

Attachment: Bug 1878846 - Change grid items to use PerLogicalAxis types. r=#layout

This avoids using raw integer values which might cause bugs.
Also removed a clang-format: off block for better formatting.

Comment 2

[Tiaan Louw [:tlouw]]

Attachment: Bug 1878846 - Take writing mode into account when calculating baseline sharing group. r=#layout

https://drafts.csswg.org/css-align-3/#baseline-terms
The baseline sharing group is not equal to the baseline specified for
the item. It has to be calculated separately. The baseline sharing
group determines on which side of the block the item is aligned, but the
specified baseline is still used to determine the baseline of the item.

Depends on D200767

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cab51450b6bd
Change grid items to use PerLogicalAxis types. r=TYLin

Comment 4

[Cristian Tuns]

Backed out for causing build bustages in nsIFrame.h

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/layout/generic/nsIFrame.h(4522,15): error: inline function 'nsIFrame::IsMasonry' is not defined [-Werror,-Wundefined-inline]

Comment 5

[Tiaan Louw [:tlouw]]

False positive warning reported by clangd for a removed header file. Fixed and relanded.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7829576fd77e
Change grid items to use PerLogicalAxis types. r=TYLin

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6eb0c382d2f
Take writing mode into account when calculating baseline sharing group. r=layout-reviewers,dholbert,emilio

Comment 8

[Iulian Moraru]

Backed out for causing wr failures on masonry-grid-item-content-baseline-001.html.

• Push with failures

• Failure log

• Backout link

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7829576fd77e

Comment 10

[Tiaan Louw [:tlouw]]

Fixed backed out patch. Re-landing.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c59a7f7b8852
Take writing mode into account when calculating baseline sharing group. r=layout-reviewers,dholbert,emilio

Comment 12

[Norisz Fay [:noriszfay]]

Backed out for causing Wr failures on align-items-baseline-row-vert.html

Backout link

Push with failures

Failure log

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef94bf18338f
Take writing mode into account when calculating baseline sharing group. r=layout-reviewers,dholbert,emilio

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ef94bf18338f