1848366 - "New Groups" tab in subscribe dialog non-functional

Status: RESOLVED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[Hartmut Welpmann [:welpy-cw]]

Steps to reproduce:

1. Open the subscribe dialog and choose a NNTP server.
2. Click on "New Groups"
3. Click on "Refresh"

Actual results:

After step 2 nothing changes. Step 3 reloads the complete list of groups from the server.

Expected results:

Clicking on/selecting by Ctrl-Tab "New Groups" should update the tab panel accordingly. Refreshing "New Groups" should only display groups added to the server since a specific date.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

This is a regression by Bug 1707550 which hasn't implemented the NNTP NEWGROUPS functionality. ShowNewGroupsList() in subscribe.js (see here) eventually leads to a call of getListOfGroupsOnServer(server, msgWindow, getOnlyNew) in NntpService.jsm (see here which just ignores the getOnlyNew argument.

Comment 2

[Hartmut Welpmann [:welpy-cw]]

The tab panel not getting updated on the other hand seems to be a regression that happened between 65.0a1 and 66.0a1 (see smallest regression window I could get). In the last good build one could just click on a tab to change the panel. Also possible to select a tab was pressing the space key after focusing it by tab and cursor keys.

Comment 3

[Hartmut Welpmann [:welpy-cw]]

Following patch implements the NEWGROUPS command in nntp-js and restores switching the tab panel by clicking on the tabs.

While the previous NNTP implementation requested only new groups added since the last complete list, now all new groups of the last n days are retrieved, n being a pref with a preset of 180. This is possibly more useful.

Comment 4

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1848366 - Restore "New Groups" functionality in subscribe dialog. r=mkmelin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ee3af630d609
Restore "New Groups" functionality in subscribe dialog. r=mkmelin

Comment 6

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9348615 [details]
Bug 1848366 - Restore "New Groups" functionality in subscribe dialog. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): 1707550
User impact if declined: Selecting "New Groups" in subscribe dialog has no effect
Testing completed (on c-c, etc.): c-c and beta
Risk to taking this patch (and alternatives if risky): seems low

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9348615 [details]
Bug 1848366 - Restore "New Groups" functionality in subscribe dialog. r=mkmelin

[Triage Comment]
Approved for esr115

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 115.2.3:
https://hg.mozilla.org/releases/comm-esr115/rev/c39d4157391d