1848695 - Show analysis needed card if a product URL initially returns the "not enough reviews" response

Status: VERIFIED FIXED

(Firefox :: Shopping, task, P1)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

If the initial product analysis API request for a given product URL returns a "not enough reviews" error, we don't want to show the "not enough reviews" error state. Instead, we want to show the "analysis needed" card, inviting users to analyze the product.

If the user then clicks on the analyze link, and after polling / waiting, the analysis step returns the "not enough reviews" response, we do then want to show the not enough reviews error state.

The reason for this change is that a product can go from not having analyzable reviews to having lots of analyzable reviews, but the fakespot server can't tell this change has happened, so we would either need to show a card that says something like, "Not enough reviews to analyze last time, but click here to try again", or we can just show users the usual "no data yet; click to analyze" screen. The latter is simpler for us to build, and simpler for users to understand (either we have the info, or we don't).2

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

marking in-progress work as P1

Comment 2

[Amy Churchwell [:amy]]

Attachment: Bug 1848695 - show unanalyzed product card if it's the initial page load of a product without enough reviews. r=#shopping-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5aeeaee0f5ba
show unanalyzed product card if it's the initial page load of a product without enough reviews. r=shopping-reviewers,jhirsch

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5aeeaee0f5ba

Comment 5

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 9355417 [details]
Bug 1848695 - show unanalyzed product card if it's the initial page load of a product without enough reviews. r=#shopping-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Our shopping experiment relies on user interaction to update the fakespot cache of product information. Products without enough reviews display a "not enough reviews" card in the sidebar that doesn't allow users to trigger a new analysis. If a product didn't have enough reviews the last time it was analyzed, but has gotten many reviews since, this patch gives users the ability to trigger a new analysis by showing the "analyze this new product" card, which does have an analysis button.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Find a product with not enough reviews. On the first visit, with this patch applied, the "unanalyzed product" card should be shown. After clicking the button and waiting for analysis to complete, the "not enough reviews" card should then be shown. In previous beta, the "not enough reviews" card would be shown initially.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The shopping experiment is limited to a very small audience in 119.

This patch only touches a small code path in the sidebar UI code, altering which card is shown in one particular edge case.

This patch is well covered by automated tests.

• String changes made/needed: None
• Is Android affected?: No

Comment 6

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

Comment on attachment 9355417 [details]
Bug 1848695 - show unanalyzed product card if it's the initial page load of a product without enough reviews. r=#shopping-reviewers

Approved for 119.0b4

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/312dcab20144

Comment 8

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Beta 119.0b4 as well as our latest Nightly build 120.0a1 (2023-10-03).