1848697 - push-langpacks shouldn't run if no string changes occurred for a release

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Rob Lemley [:rjl]]

The push-langpacks CI job runs during the push phase of every release on beta and esr115 regardless of whether or not any string changes were made.

This is not really an issue for beta, which has frequent string updates, but on c-esr115, l10n-changesets.json is not really updated after the 4th or 5th minor version. This means that there are potentially multiple langpack versions for 115 that are the same strings.

No other jobs in the release taskgraph depend on push-langpacks, so optimizing it out based on whether or not l10n-changesets.json changes should be sufficient.

Comment 1

[Rob Lemley [:rjl]]

Attachment: WIP: Bug 1848697 - Don't push langpacks if no string changes occurred for a release.

Comment 2

[Rob Lemley [:rjl]]

This is a lot harder than it seems...

It's possible, but the difficult part is finding the right vcs tag name for the most recent previous release on the correct branch.

At first i thought it could be done with a simple hg log command with some creatively written template: hg log -r . -T {latesttag(r're:^.*RELEASE$')}

That would mostly work, but it fails if for some reason the branch you're building doesn't align with taskgraph's decision parameters (like on a try build, which may not have the right tags).

This would be much easier with a comm-unified repository.

Putting this on the back burner for now.

Comment 3

[Daniel Darnell [:dandarnell]]

Attachment: Bug 1848697 - Disable langpack push when locales have not changed. r=#thunderbird-build-system-reviewers

Comment 4

[Daniel Darnell [:dandarnell]]

Attachment: Bug 1848697 - Disable langpack push when locales have not changed. r=#thunderbird-build-system-reviewers

Comment 5

[Rob Lemley [:rjl]]

Attachment: Bug 1848697 - Selectively push langpacks to ATN by version. r=#thunderbuild

Langpacks do not change that much after beta merges to release, so only push
langpacks for major releases and minor esr releases.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/decbf44a9413
Selectively push langpacks to ATN by version. r=dandarnell