Closed Bug 1848733 Opened 10 months ago Closed 10 months ago

Letter grade component incorrectly displays long strings

Categories

(Firefox :: Shopping, defect, P2)

defect

Tracking

()

RESOLVED FIXED
119 Branch
Tracking Status
firefox119 --- fixed

People

(Reporter: kpatenio, Assigned: kpatenio)

References

Details

(Whiteboard: [fidefe-shopping])

Attachments

(2 files)

Above is the expected appearance of the letter grade component on Figma. We want to ensure that the letter grade component stretches and is able to accommodate long strings. However, the component does not behave this way currently and instead overflows past the sidebar.

Attachment #9348949 - Attachment description: Capture d’écran, le 2023-08-14 à 16.30.09.png → expected-appearance-long-string.png
Severity: -- → S3
Priority: -- → P2
Whiteboard: [fidefe-shopping]

I suspect this has something to do with setting a fixed height for the letter-grade component. I can look into this.

Assignee: nobody → kpatenio
Attachment #9349461 - Attachment description: WIP: Bug 1848733 - make letter-grade height expand with longer strings. r=#shopping-reviewers! → Bug 1848733 - make letter-grade height expand with longer strings. r=#shopping-reviewers!
Pushed by kpatenio@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bd540bacea2e
make letter-grade height expand with longer strings. r=shopping-reviewers,Gijs
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
Regressions: 1853480
No longer regressions: 1853480
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: