Closed Bug 1853480 Opened 8 months ago Closed 8 months ago

32-bit Windows Firefox can't log into mozilla.slack.com: “InternalError: too much recursion”

Tracking

()

Status:

VERIFIED FIXED

Milestone:

119 Branch

Tracking Flags:

Tracking

Status

firefox-esr102

---

unaffected

firefox-esr115

---

unaffected

firefox117

---

unaffected

firefox118

---

unaffected

firefox119

verified

People

(Reporter: cpeterson, Assigned: arai)

References

(Regression)

Details

(Keywords: regression, regressionwindow-wanted)

Attachments

(5 files)

screenshot.png 8 months ago Chris Peterson [:cpeterson] 140.13 KB, image/png		Details
Bug 1853480 - Part 1: Use TaskController thread stack size as JS stack quota in ScriptLoader off-thread compilation. r?nbp! 8 months ago Tooru Fujisawa [:arai] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1853480 - Part 2: Use TaskController thread stack size as JS stack quota in nsXULPrototypeScript off-thread compilation. r?nbp! 8 months ago Tooru Fujisawa [:arai] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1853480 - Part 3: Use TaskController thread stack size as JS stack quota in ChromeUtils.compileScript off-thread compilation. r?nbp! 8 months ago Tooru Fujisawa [:arai] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1853480 - Part 4: Use TaskController thread stack size as JS stack quota in ScriptPreloader off-thread decode. r?nbp! 8 months ago Tooru Fujisawa [:arai] 48 bytes, text/x-phabricator-request		Details \| Review

Chris Peterson [:cpeterson]

Reporter

Description

•

8 months ago

Attached image screenshot.png — Details

I downloaded from 64-bit Windows Firefox Nightly 119 to 32-bit (to help test 32-bit) and now I can no longer log into mozilla.slack.com. I can load https://slack.com/ but when I try to log into https://mozilla.slack.com/, a wireframe of the Slack UI loads and then stops. See the attached screenshot.

I can reproduce in safe mode and a clean profile using mozregression. I've bisected this problem twice and both times landed on this autoland pushlog for bug 1848733, a small CSS change for Fakespot that should have no impact on loading Slack:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e946943d32b0061f9994c7fa29fcb0b33c3cab05&tochange=bd540bacea2eef0fa90fca78276afe5af11cdb5e

In the web console, I see InternalError: too much recursion error messages and an uncaught promise error (that I don't see when using 64-bit):

Uncaught (in promise) Error: Loading chunk gantry-v2-vendors-async failed.
(missing: https://b.slack-edge.com/bv1-10/gantry-v2-vendors-async.3afaa4a.min.js?cacheKey=gantry-1694818042)
    r https://app.slack.com/client/T027LFU12?cdn_fallback=1:1
    onload https://app.slack.com/client/T027LFU12?cdn_fallback=1:1
    e https://app.slack.com/client/T027LFU12?cdn_fallback=1:1
    r https://app.slack.com/client/T027LFU12?cdn_fallback=1:1
    onload https://app.slack.com/client/T027LFU12?cdn_fallback=1:1
    e https://app.slack.com/client/T027LFU12?cdn_fallback=1:1
    r https://app.slack.com/client/T027LFU12?cdn_fallback=1:1
    onload https://app.slack.com/client/T027LFU12?cdn_fallback=1:1
    e https://app.slack.com/client/T027LFU12?cdn_fallback=1:1
    e https://app.slack.com/client/T027LFU12?cdn_fallback=1:1
    data https://b.slack-edge.com/bv1-10/client-boot.7beeb9b.min.js?cacheKey=gantry-1694818042:40
    duHP/runBootApp/</je</ee.dynamicImportPromises[Ve]< https://b.slack-edge.com/bv1-10/gantry-v2-shared.33514c6.min.js?cacheKey=gantry-1694818042:53
    ve https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:123
    _resolveFromExecutor https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:163
    _e https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:163
    je https://b.slack-edge.com/bv1-10/gantry-v2-shared.33514c6.min.js?cacheKey=gantry-1694818042:53
    runBootApp https://b.slack-edge.com/bv1-10/gantry-v2-shared.33514c6.min.js?cacheKey=gantry-1694818042:53
    tryCatcher https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:187
    _promiseFulfilled https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:144
    _settlePromise https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:163
    _fulfillPromises https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:163
    _settlePromises https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:163
    A https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:117
    f https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:117
    _drainQueues https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:117
    drainQueues https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:113
    promise callback*xu</9oTK/</</<[29]</e< https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:178
    _queueTick https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:117
    m https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:117
    _fulfill https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:163
    _resolveCallback https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:163
    R https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:187
    promise callback*tryCatcher https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:187
    p https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:187
    c https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:187
    _resolveCallback https://b.slack-edge.com/bv1-10/gantry-v2-vendors.05680d8.min.js?cacheKey=gantry-1694818042:163

Chris Peterson [:cpeterson]

Reporter

Updated

•

8 months ago

Summary: 32-bit Windows Firefox can't log into mozilla.slack.com → 32-bit Windows Firefox can't log into mozilla.slack.com: “InternalError: too much recursion”

Yannis Juglaret [:yannis]

Comment 1

•

8 months ago

•

Edited

Thanks for reporting. I can reproduce and bisecting also leads me to the same commit. Marking bug 1848733 as the regressor for the moment then. I will investigate a bit.

Regressed by: 1848733

BugBot [:suhaib / :marco/ :calixte]

Comment 2

•

8 months ago

:kpatenio, since you are the author of the regressor, bug 1848733, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(kpatenio)

Yannis Juglaret [:yannis]

Comment 3

•

8 months ago

•

Edited

I pushed to try and the issue doesn't seem to reproduce in non-official Nightly builds, so I would assume that we cannot trust mozregression here when we start regressing between official Nightly builds' commits, which could explain why bug 1848733 would be wrongly identified as the regressor here (it is the commit for an official Nightly build).

I suggest we look at the wider regression range between official builds and I'm thus tempted to blame bug 1845638 because it's about js::FrontendContext. Please correct this if I'm wrong.

I reach:

0:032> k 600
 # ChildEBP RetAddr      
00 1760fe84 5db2d80f     xul!js::FrontendContext::onOverRecursed
01 (Inline) --------     xul!js::AutoCheckRecursionLimit::check+0x9ff4 [/builds/worker/workspace/obj-build/dist/include/js/friend/StackLimits.h @ 225] 
02 17610200 5db24c80     xul!js::frontend::BytecodeEmitter::emitTree+0xa01f [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 11728] 
03 (Inline) --------     xul!js::frontend::BytecodeEmitter::emitLeftAssociative+0x14 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 8325] 
04 17610580 5db32309     xul!js::frontend::BytecodeEmitter::emitTree+0x1490 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 11965] 
05 (Inline) --------     xul!js::frontend::BytecodeEmitter::emitPropertyList::<lambda_0>::operator()+0x22 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 9057] 
06 (Inline) --------     xul!js::frontend::BytecodeEmitter::emitPropertyList+0x13f [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 9188] 
07 176108b8 5db25d95     xul!js::frontend::BytecodeEmitter::emitObject+0x7e9 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 10778] 
08 17610c30 5db256e1     xul!js::frontend::BytecodeEmitter::emitTree+0x25a5 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 12189] 
09 (Inline) --------     xul!js::frontend::BytecodeEmitter::emitInitializer+0x1b [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 3124] 
0a (Inline) --------     xul!js::frontend::BytecodeEmitter::emitSingleDeclaration+0x1a6 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 3999] 
0b (Inline) --------     xul!js::frontend::BytecodeEmitter::emitDeclarationList+0x213 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 3933] 
0c 17610fb0 5db24229     xul!js::frontend::BytecodeEmitter::emitTree+0x1ef1 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 11831] 
0d (Inline) --------     xul!js::frontend::BytecodeEmitter::emitStatementList+0x1e [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 6880] 
0e 17611330 5db2fc46     xul!js::frontend::BytecodeEmitter::emitTree+0xa39 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 11873] 
0f (Inline) --------     xul!js::frontend::BytecodeEmitter::emitLexicalScopeBody+0x3a [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 4942] 
10 17611398 5db2424d     xul!js::frontend::BytecodeEmitter::emitLexicalScope+0x96 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 4957] 
11 17611710 5db2594b     xul!js::frontend::BytecodeEmitter::emitTree+0xa5d [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 12137] 
12 (Inline) --------     xul!js::frontend::TernaryNode::kid2+0x12 [/builds/worker/checkouts/gecko/js/src/frontend/ParseNode.h @ 1156] 
13 (Inline) --------     xul!js::frontend::BytecodeEmitter::emitIf+0x1cb [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 4867] 
14 17611a90 5db24229     xul!js::frontend::BytecodeEmitter::emitTree+0x215b [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 11755] 
15 (Inline) --------     xul!js::frontend::BytecodeEmitter::emitStatementList+0x1e [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 6880] 
16 17611e10 5db2fc46     xul!js::frontend::BytecodeEmitter::emitTree+0xa39 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 11873] 
17 (Inline) --------     xul!js::frontend::BytecodeEmitter::emitLexicalScopeBody+0x3a [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 4942] 
18 17611e78 5db2424d     xul!js::frontend::BytecodeEmitter::emitLexicalScope+0x96 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 4957] 
19 176121f8 5d2420b1     xul!js::frontend::BytecodeEmitter::emitTree+0xa5d [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 12137] 
1a (Inline) --------     xul!js::frontend::BytecodeEmitter::emitCStyleFor+0x16f [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 5801] 
1b 17612324 5db26c5c     xul!js::frontend::BytecodeEmitter::emitFor+0x1c1 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 5838] 
1c 176126a0 5db24229     xul!js::frontend::BytecodeEmitter::emitTree+0x346c [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 11779] 
1d (Inline) --------     xul!js::frontend::BytecodeEmitter::emitStatementList+0x1e [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 6880] 
1e 17612a20 5db2fc46     xul!js::frontend::BytecodeEmitter::emitTree+0xa39 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 11873] 
1f (Inline) --------     xul!js::frontend::BytecodeEmitter::emitLexicalScopeBody+0x3a [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 4942] 
20 17612a88 5db2424d     xul!js::frontend::BytecodeEmitter::emitLexicalScope+0x96 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 4957]

... then a lot of other similar calls, ending with:

5b7 1768d468 5db303cd     xul!js::frontend::BytecodeEmitter::emitTree+0xa5d [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 12137] 
5b8 (Inline) --------     xul!js::frontend::BytecodeEmitter::emitFunctionScript+0x1e2 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 2514] 
5b9 1768d828 5db249fa     xul!js::frontend::BytecodeEmitter::emitFunction+0x44d [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 5890] 
5ba 1768dba0 5db2758a     xul!js::frontend::BytecodeEmitter::emitTree+0x120a [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 11744] 
5bb (Inline) --------     xul!js::frontend::CallOrNewEmitter::prepareForOtherCallee+0x1a [/builds/worker/checkouts/gecko/js/src/frontend/CallOrNewEmitter.cpp @ 133] 
5bc (Inline) --------     xul!js::frontend::BytecodeEmitter::emitCalleeAndThis+0x381c [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 7931] 
5bd (Inline) --------     xul!js::frontend::BytecodeEmitter::emitCallOrNew+0x3954 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 8238] 
5be 1768df20 5db2465d     xul!js::frontend::BytecodeEmitter::emitTree+0x3d9a [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 12131] 
5bf (Inline) --------     xul!js::frontend::BytecodeEmitter::emitExpressionStatement+0x33d [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 6935] 
5c0 1768e2a0 5db24229     xul!js::frontend::BytecodeEmitter::emitTree+0xe6d [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 11882] 
5c1 (Inline) --------     xul!js::frontend::BytecodeEmitter::emitStatementList+0x1e [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 6880] 
5c2 1768e624 5d23c112     xul!js::frontend::BytecodeEmitter::emitTree+0xa39 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 11873] 
5c3 1768e728 5d249381     xul!js::frontend::BytecodeEmitter::emitScript+0x102 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeEmitter.cpp @ 2414] 
5c4 (Inline) --------     xul!ScriptCompiler<mozilla::Utf8Unit>::compile+0x2a0 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeCompiler.cpp @ 994] 
5c5 1768f42c 5d237f82     xul!CompileGlobalScriptToStencilAndMaybeInstantiate<mozilla::Utf8Unit>+0x441 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeCompiler.cpp @ 335] 
5c6 (Inline) --------     xul!CompileGlobalScriptToStencilImpl+0x1b [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeCompiler.cpp @ 406] 
5c7 1768f460 5d0839ca     xul!js::frontend::CompileGlobalScriptToStencil+0x42 [/builds/worker/checkouts/gecko/js/src/frontend/BytecodeCompiler.cpp @ 426] 
5c8 (Inline) --------     xul!CompileGlobalScriptToStencilImpl+0xb0 [/builds/worker/checkouts/gecko/js/src/frontend/CompileScript.cpp @ 127] 
5c9 1768f4dc 5cbf36b3     xul!JS::CompileGlobalScriptToStencil+0xca [/builds/worker/checkouts/gecko/js/src/frontend/CompileScript.cpp @ 166] 
5ca (Inline) --------     xul!mozilla::dom::ScriptOrModuleCompileTask<0>::Compile::<lambda_1>::operator()+0x10 [/builds/worker/checkouts/gecko/dom/script/ScriptLoader.cpp @ 1799] 
5cb (Inline) --------     xul!mozilla::MaybeOneOf<JS::SourceText<char16_t>,JS::SourceText<mozilla::Utf8Unit> >::mapNonEmpty+0x19 [/builds/worker/workspace/obj-build/dist/include/mozilla/MaybeOneOf.h @ 148] 
5cc (Inline) --------     xul!mozilla::dom::ScriptOrModuleCompileTask<0>::Compile+0x46 [/builds/worker/checkouts/gecko/dom/script/ScriptLoader.cpp @ 1805] 
5cd 1768f518 5d735502     xul!mozilla::dom::ScriptOrModuleCompileTask<0>::Run+0x73 [/builds/worker/checkouts/gecko/dom/script/ScriptLoader.cpp @ 1786] 
5ce (Inline) --------     xul!mozilla::TaskController::RunPoolThread+0x8e2 [/builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp @ 357] 
5cf 1768f784 633d6a90     xul!mozilla::ThreadFuncPoolThread+0x932 [/builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp @ 206] 
5d0 1768f7b8 6344d8b6     nss3!_PR_NativeRunThread+0x140 [/builds/worker/checkouts/gecko/nsprpub/pr/src/threads/combined/pruthr.c @ 421] 
5d1 1768f7c8 76e859d3     nss3!pr_root+0x16 [/builds/worker/checkouts/gecko/nsprpub/pr/src/md/windows/w95thred.c @ 139] 
5d2 1768f800 76447ba9     ucrtbase!thread_start<unsigned int (__stdcall*)(void *),1>+0x43
5d3 1768f810 650f4e9f     KERNEL32!BaseThreadInitThunk+0x19
5d4 (Inline) --------     mozglue!mozilla::interceptor::FuncHook<mozilla::interceptor::WindowsDllInterceptor<mozilla::interceptor::VMSharingPolicyShared>,void (*)(int, void *, void *) __attribute__((fastcall))>::operator()+0x9 [/builds/worker/checkouts/gecko/toolkit/xre/dllservices/mozglue/nsWindowsDllInterceptor.h @ 150] 
5d5 1768f844 76fdb79b     mozglue!patched_BaseThreadInitThunk+0x1f [/builds/worker/checkouts/gecko/toolkit/xre/dllservices/mozglue/WindowsDllBlocklist.cpp @ 566] 
5d6 1768f89c 76fdb71f     ntdll!__RtlUserThreadStart+0x2b
5d7 1768f8ac 00000000     ntdll!_RtlUserThreadStart+0x1b

Note: The debugger can wrongly display a webrtc function as the top function on the stack because xul!js::FrontendContext::onOverRecursed is compiled to the same bytes in the binary as some webrtc functions.

0:032> ln 5ff01f50
Exact matches:
    xul!js::FrontendContext::onOverRecursed (void)
    xul!webrtc::AudioBuffer::set_downmixing_by_averaging (void)
    xul!webrtc::voe::`anonymous namespace'::ChannelReceive::StartPlayout (void)

Component: General → JavaScript Engine

OS: Unspecified → Windows

Product: Firefox → Core

Regressed by: 1845638
No longer regressed by: 1848733

Hardware: Unspecified → x86

Version: unspecified → Firefox 119

Yannis Juglaret [:yannis]

Updated

•

8 months ago

Flags: needinfo?(kpatenio)

Tooru Fujisawa [:arai]

Assignee

Comment 4

•

8 months ago

testing a patch to apply the same stack quota as before
https://treeherder.mozilla.org/jobs?repo=try&revision=57e69f31eb057b8f14722f7e9dccec399e246977
(there seems to be large latency on the automation and the job doesn't yet appear tho...)

Assignee: nobody → arai.unmht

Status: NEW → ASSIGNED

Donal Meehan [:dmeehan]

Updated

•

8 months ago

tracking-firefox119: --- → +

Tooru Fujisawa [:arai]

Assignee

Comment 5

•

8 months ago

observed the issue locally, and also confirmed the fix with https://treeherder.mozilla.org/jobs?repo=try&revision=57e69f31eb057b8f14722f7e9dccec399e246977

Tooru Fujisawa [:arai]

Assignee

Comment 6

•

8 months ago

Attached file Bug 1853480 - Part 1: Use TaskController thread stack size as JS stack quota in ScriptLoader off-thread compilation. r?nbp! — Details

Tooru Fujisawa [:arai]

Assignee

Comment 7

•

8 months ago

Attached file Bug 1853480 - Part 2: Use TaskController thread stack size as JS stack quota in nsXULPrototypeScript off-thread compilation. r?nbp! — Details

Depends on D188556

Tooru Fujisawa [:arai]

Assignee

Comment 8

•

8 months ago

Attached file Bug 1853480 - Part 3: Use TaskController thread stack size as JS stack quota in ChromeUtils.compileScript off-thread compilation. r?nbp! — Details

Depends on D188557

Tooru Fujisawa [:arai]

Assignee

Comment 9

•

8 months ago

Attached file Bug 1853480 - Part 4: Use TaskController thread stack size as JS stack quota in ScriptPreloader off-thread decode. r?nbp! — Details

Depends on D188558

Tooru Fujisawa [:arai]

Assignee

Updated

•

8 months ago

Duplicate of this bug: 1853752

Tooru Fujisawa [:arai]

Assignee

Updated

•

8 months ago

Blocks: 1853881

Pulsebot

Comment 11

•

8 months ago

Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/d29bfc33c3e8
Part 1: Use TaskController thread stack size as JS stack quota in ScriptLoader off-thread compilation. r=nbp
https://hg.mozilla.org/integration/autoland/rev/975251abd222
Part 2: Use TaskController thread stack size as JS stack quota in nsXULPrototypeScript off-thread compilation. r=nbp
https://hg.mozilla.org/integration/autoland/rev/f686d2dccfd6
Part 3: Use TaskController thread stack size as JS stack quota in ChromeUtils.compileScript off-thread compilation. r=nbp
https://hg.mozilla.org/integration/autoland/rev/153828203749
Part 4: Use TaskController thread stack size as JS stack quota in ScriptPreloader off-thread decode. r=nbp

Narcis Beleuzu [:NarcisB]

Comment 12

•

8 months ago

Backed out for bustages on ScriptPreloader.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/96fdfa114c7ef4c0696fb792d730fe29133fda99
Log link: https://treeherder.mozilla.org/logviewer?job_id=429649823&repo=autoland&lineNumber=41873

Flags: needinfo?(arai.unmht)

Pulsebot

Comment 13

•

8 months ago

Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/520f2c9eeb7c
Part 1: Use TaskController thread stack size as JS stack quota in ScriptLoader off-thread compilation. r=nbp
https://hg.mozilla.org/integration/autoland/rev/c810b86e489d
Part 2: Use TaskController thread stack size as JS stack quota in nsXULPrototypeScript off-thread compilation. r=nbp
https://hg.mozilla.org/integration/autoland/rev/cba4b151baba
Part 3: Use TaskController thread stack size as JS stack quota in ChromeUtils.compileScript off-thread compilation. r=nbp
https://hg.mozilla.org/integration/autoland/rev/9ae7c2b8c50e
Part 4: Use TaskController thread stack size as JS stack quota in ScriptPreloader off-thread decode. r=nbp

Gian-Carlo Pascutto [:gcp]

Comment 14

•

8 months ago

I pushed to try and the issue doesn't seem to reproduce in non-official Nightly builds, so I would assume that we cannot trust mozregression here when we start regressing between official Nightly builds' commits, which could explain why bug 1848733 would be wrongly identified as the regressor here (it is the commit for an official Nightly build).

Do we understand why this has an effect here?

Nicolas B. Pierron [:nbp]

Updated

•

8 months ago

Severity: -- → S2

Priority: -- → P1

Atila Butkovits

Comment 15

•

8 months ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/520f2c9eeb7c
https://hg.mozilla.org/mozilla-central/rev/c810b86e489d
https://hg.mozilla.org/mozilla-central/rev/cba4b151baba
https://hg.mozilla.org/mozilla-central/rev/9ae7c2b8c50e

Status: ASSIGNED → RESOLVED

Closed: 8 months ago

status-firefox119: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → 119 Branch

Tooru Fujisawa [:arai]

Assignee

Comment 16

•

8 months ago

(In reply to Gian-Carlo Pascutto [:gcp] from comment #14)

I pushed to try and the issue doesn't seem to reproduce in non-official Nightly builds, so I would assume that we cannot trust mozregression here when we start regressing between official Nightly builds' commits, which could explain why bug 1848733 would be wrongly identified as the regressor here (it is the commit for an official Nightly build).

Do we understand why this has an effect here?

It does reproduce for me with try build, windows 2012 shippable.

Flags: needinfo?(arai.unmht)

Yannis Juglaret [:yannis]

Comment 17

•

8 months ago

•

Edited

(In reply to Tooru Fujisawa [:arai] from comment #16)

It does reproduce for me with try build, windows 2012 shippable.

I was indeed not testing with shippable. Probably mozregression also doesn't restrict to shippable, because otherwise it would be harder to find builds between two official commits? Do we know why only shippable builds reproduce the issue then?

Tooru Fujisawa [:arai]

Assignee

Comment 18

•

8 months ago

Confirmed that the issue doesn't happen on non-shippable opt build.
This is likely because of PGO affects the inlining, which can result in the different size of stack consumption in the bytecode emitter,
and it hits stack quota only in specific configuration.

Chris Peterson [:cpeterson]

Reporter

Comment 19

•

8 months ago

I verified Slack works for me in today's 32-bit Nightly 119.0a1 build 2023-09-20.

Status: RESOLVED → VERIFIED

status-firefox119: fixed → verified

You need to log in before you can comment on or make changes to this bug.