1848860 - Do not prompt to save/update credit card unless all required fields are present

Status: RESOLVED FIXED

(Fenix :: Autofill, enhancement, P3)

Description

[Matt Tighe [:matt-tighe]]

In Bug 1839158 we added a quick fix for a crash that was caused by trying to save credit cards with empty strings. Parsing the empty strings to longs was causing exceptions.

Afterwards, UX feedback indicated that the best way to handle this was to not display the save/update prompt unless we had all required information.

Steps to reproduce

1. Navigate to https://checkout.stripe.dev/preview
2. Try to save a credit card with a blank expiry month or year

Expected behavior

The prompt does not appear

Actual behavior

The prompt appears but clicking save/update silently fails

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1848860 - Do not prompt to save/update credit card unless all required fields are present (#3447)

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

To capture the UX decision:

My first instinct is that the patch is providing a good UX by not interrupting the user when CC info is incomplete. Because the user is performing a task (shopping/checking out), I hesitate to take them away from that flow to provide us with more info so they can save their card to use next time.
To sum it up, to me it makes sense to ONLY ask to save/update CC info when we have all of the info in that moment.

Comment 4

[BMO Github Automation]

Authored by https://github.com/t-p-white
https://github.com/mozilla-mobile/firefox-android/commit/c23f12b7792ca20fc28a07a9dd414b558c8a0ffd
[main] Bug 1848860 - Do not prompt to save/update credit card unless all required fields are present

Comment 5

[Lorand Janos]

Verified on the latest Nightly 119.0a1 from 2023-09-07.
No prompt is displayed when trying to pay with empty expiry month and year field.
An error message is displayed on the page pointing out that there's an information missing.
Devices used:

• Google Pixel 7 (Android 14).
• Redmi 9C NFC (Android 10).
  Marking the ticket as verified for 119.