1848899 - Remove widget.non-native-theme.enabled pref

Status: RESOLVED FIXED

(Core :: Widget, task)

Description

[Gregory Pappas [:gregp]]

Non-native theming of widgets in content has been enabled by default for about 2 years now (bug 1697053). Should be safe to remove this pref now

Comment 1

[Gregory Pappas [:gregp]]

One benefit of doing this is that it will be harder to accidentally turn off win32k lockdown
https://searchfox.org/mozilla-central/rev/f1f50693655c093d974f026bd37860d939cd5529/toolkit/xre/nsAppRunner.cpp#803-806

Comment 2

[Gregory Pappas [:gregp]]

Emilio, do you have any concerns about this?

Comment 3

[Thorin [:thorin]]

as long as other prefs don't affect it, because it's also a fingerprint protection

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Yeah, I guess it might be useful to test the native theme on content, but given we already render most of the stuff using the non-native theme I'm fine just removing it.

Comment 5

[Tom S. (please needinfo tschuster)]

This came up again in https://phabricator.services.mozilla.com/D207442, probably a good thing to remove it.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1848899 - Remove widget.non-native-theme.enabled. r=#layout

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9500b79c1ab4
Remove widget.non-native-theme.enabled. r=desktop-theme-reviewers,dao,dholbert

Comment 8

[Norisz Fay [:noriszfay]]

Backed out for causing failures on test_bug869314.html

Backout link

Push with failures

Failure log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c9f9407d659
Remove widget.non-native-theme.enabled. r=desktop-theme-reviewers,dao,dholbert

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2c9f9407d659