Remove unifiedSearchSettings feature flags
Categories
(Firefox for Android :: Search, task, P3)
Tracking
()
People
(Reporter: gl, Assigned: royang)
References
(Blocks 2 open bugs)
Details
(Keywords: leave-open)
Attachments
(10 files)
|
59 bytes,
text/x-github-pull-request
|
Details | Review | |
|
59 bytes,
text/x-github-pull-request
|
Details | Review | |
|
59 bytes,
text/x-github-pull-request
|
Details | Review | |
|
59 bytes,
text/x-github-pull-request
|
Details | Review | |
|
59 bytes,
text/x-github-pull-request
|
Details | Review | |
|
59 bytes,
text/x-github-pull-request
|
Details | Review | |
|
59 bytes,
text/x-github-pull-request
|
Details | Review | |
|
[mozilla-mobile/firefox-android] Bug 1849073 - Part 5: Remove the Add Search Engine fragment (#4055)
59 bytes,
text/x-github-pull-request
|
Details | Review | |
|
59 bytes,
text/x-github-pull-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
Since we have enabled in unified search by default in all our builds, we should clean up the unifiedSearchSettings feature flags.
|
||
Comment 1•2 years ago
|
||
|
|
||
Comment 2•2 years ago
|
||
|
|
||
Comment 3•2 years ago
|
||
|
|
||
Comment 4•2 years ago
|
||
|
Reporter | |
Updated•2 years ago
|
|
|
||
Comment 5•2 years ago
|
||
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/62d6588baaf9378767fa29f32ea4668455356567
[main] Bug 1849073 - Part 1: Remove the Bookmark Search Dialog
|
|
||
Comment 6•2 years ago
|
||
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/ebe7186b81d71e2502030f010a3a5a07d5fd3d2e
[main] Bug 1849073 - Part 2: Remove the History Search Dialog
|
|
||
Comment 7•2 years ago
|
||
|
|
||
Comment 8•2 years ago
|
||
|
|
||
Comment 9•2 years ago
|
||
|
|
||
Comment 10•2 years ago
|
||
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/3f23b93cb0d9b2ce0fe09c36586eb55a045d1277
[main] Bug 1849073 - Part 3: Remove trivial showUnifiedSearchFeature and enableUnifiedSearchSettingsUI checks
|
|
||
Comment 11•2 years ago
|
||
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/4b8f76143317d2d172f5094c95dc53eea53c0681
[main] Bug 1849073 - Part 4: Remove the Edit Custom Search Engine fragment
|
|
||
Comment 12•2 years ago
|
||
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/c907385cbcca8236da0e69fd9912d0d835a7c2f8
[main] Bug 1849073 - Part 6: Remove the old search preferences
|
|
||
Comment 13•2 years ago
|
||
|
|
||
Comment 14•2 years ago
|
||
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/4851d6f7db4b642530a3fed2d0ea9341eda53412
[main] Bug 1849073 - Part 5: Remove the Add Search Engine fragment
|
||
Comment 15•2 years ago
|
||
gl, does this bug still need to be left open? Should we also remove the hiddenEnginesRestored flag in bug 1850767 now?
|
|
Reporter | |
Comment 16•2 years ago
|
||
This bug is still needed since not everything has been removed. The hiddenEnginesRestored flag seems pretty standalone from the unified search feature flag so I will leave for someone else to determine the appropriate timing in Bug 1850767.
|
|
||
Comment 17•2 years ago
|
||
Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/3e77ac03af596a8c7fc5bfedc5802895d2553a72
[main] Bug 1849073 - Part 7: Remove pill wrapper in search dialog
|
|
||
Comment 18•2 years ago
|
||
|
||
Comment 19•1 year ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:skhan, maybe it's time to close this bug?
For more information, please visit BugBot documentation.
|
Assignee | |
Comment 22•1 year ago
|
||
|
||
Updated•1 year ago
|
|
||
Comment 23•1 year ago
|
||
|
|
Assignee | |
Updated•1 year ago
|
|
||
Comment 24•1 year ago
|
||
| bugherder | ||
Description
•