1850767 - Remove hiddenEnginesRestored flag once migration is not needed

Status: NEW

(Firefox for Android :: Search, defect, P3)

Description

[Mike a [:mavduevskiy]]

hiddenEnginesRestored is being used to support switching to the new search settings screen. The old version had hide/restore mechanism, but the new doesn't. So we restored the hidden engines for the new UI. However, once we could expect the majority of users to use versions that support migration for a few releases, we should remove the flag and the check. My hunch would be 2-3 releases, but better check the usage of 117 version – it didn't support the migration.

Comment 1

[Jonathan Almeida [:jonalmeida]]

Corrected related bugs.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

This bug has been marked as a regression. Setting status flag for Nightly to affected.

Comment 3

[Donal Meehan [:dmeehan]]

Clearing the regression keyword, re: comment 1

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:skhan, could you have a look please?

For more information, please visit BugBot documentation.

Comment 5

[Matt Tighe [:matt-tighe]]

Hey Mike - randomly stumbled across this code today and was wondering if it was now safe to remove?

Comment 6

[Mike a [:mavduevskiy]]

Hey! It's been two years, so the only people who might run into a problem here would be users who have hidden engines, skipped 2 years of updates and updated the app now :)

I believe we also should remove more code, like HideSearchEngineAction, it's not being used any more.

For context: we used to have a different UI and UX here, there was just one radio button list of engines. Because it was radio button list, the only way to adjust visibility would be go into the menu of an item and remove (hide) it. So that the item didn't appear in the search settings and in the address bar as well. Later on we revisited the UX here, and introduced a checkbox list of engines, so that users could check and uncheck items they want to see in the search engines list in addressbar. We still have the ability to remove a custom engine or additional search engine, but those will be removed for good, not hidden. So, there is a good chance we should remove the SearchState.hiddenSearchEngines all-together as we don't use it anymore.