1849292 - Buzzing sounds coming from speaker when playing videos on certain websites

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Firefox Reporter]

Steps to reproduce:

1. Download the latest version of Firefox Nightly from Google Play
2. Open http://gogoanime3.net/watashi-no-shiawase-na-kekkon-episode-7
3. Play the video, a constant buzzing noise comes out of the right channel speakers while the audio levels from the video are higher than silence.

I thought at first my speakers on my brand new tablet were going out, but no, this issue does not happen in Chrome. It also doesn't happen on the latest build of Firefox stable for Android (116.3.0). It only happens on nightly.

The Android device used is Galaxy Tab S8+, model SM-X800.
One UI version 5.1. Android version 13. Android security patch May 1, 2023.

Actual results:

A buzzing sound comes out of the speakers when playing HTML5 videos from certain websites (youtube doesn't appear to be affected).

Expected results:

Normal audio should play, no buzzing sounds.

Comment 1

[Firefox Reporter]

Upon further testing, the last version where this worked correctly (no speaker cracking), is:
2015967139 (2023-08-09 release)

Which means the next release is where this issue started occurring:
2015967251 (2023-08-10 release)

This should greatly narrow down which part of the code you need to look at to identify what caused the issue.

Comment 2

[Adina Petridean QA [:apetridean]]

@giwayume thank you for your report! I was able to reproduce the issue on latest Nightly - 118.0a1 from 18.08.2023 with Motorola Moto G9 plus (Android 11).

Comment 3

[jackyzy823]

Depends on your info: Bug may happen between https://hg.mozilla.org/mozilla-central/shortlog/b8482a775ba470a9e13b71cb570e5df2d5d03687 and https://hg.mozilla.org/mozilla-central/shortlog/1f46af18938c502599b89d62cb0c1d9a221b3126

Comment 4

[Paul Adenot (:padenot)]

Reporter, thanks for filing, would you mind telling me what's audio backend is in use on your device by going to about:support, scrolling down to the Media section?

It should say AAudio, or OpenSL ? I have a fix ready, but I want to make sure your problem isn't something else.

Comment 5

[Paul Adenot (:padenot)]

Nevermind, I can reproduce on a completely different device, it's something else related to AAC decoding, I'll get a patch.

Comment 6

[Firefox Reporter]

Audio backend is aaudio

Comment 7

[Paul Adenot (:padenot)]

Perfect, that matches what I'm seeing locally on a Pixel 4. Patch incoming, thanks for providing details.

Comment 8

[Paul Adenot (:padenot)]

Attachment: Bug 1849292 - Fix off by one in InflatableShortBuffer. r?#media-playback-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/651b9362eee8
Fix off by one in InflatableShortBuffer. r=media-playback-reviewers,alwu

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/651b9362eee8

Comment 11

[Chris Peterson [:cpeterson]]

Paul, a Firefox 117.0.2 dot release is planned for next week. Do you think this Android fix would be a good ride-along fix? Does this bug affect both Android and desktop?

Comment 12

[Paul Adenot (:padenot)]

(In reply to Chris Peterson [:cpeterson] from comment #11)

Paul, a Firefox 117.0.2 dot release is planned for next week. Do you think this Android fix would be a good ride-along fix? Does this bug affect both Android and desktop?

117 isn't affected, https://bugzilla.mozilla.org/show_bug.cgi?id=1833654 landed in 118.