1849554 - The Active Fakespot Address bar icon is not properly displayed with High Contrast when hovered over

Status: VERIFIED FIXED

(Firefox :: Shopping, defect, P1)

Description

[Rares Doghi, Desktop QA]

Attachment: ddressshopping.png

Found in

• Nightly 118.0a1 (2023-08-21)

Affected versions

• Nightly 118.0a1 (2023-08-21)

Affected platforms

• Windows

Preconditions:
Set the browser.shopping.experience2023.enabled - TRUE
Enable High Contrast.

Steps to reproduce

1. Reach https://www.walmart.com/ip/Home-Office-Chair-Big-Tall-Chair-8-Hours-Heavy-Duty-Design-Ergonomic-High-Back-Cushion-Lumbar-Support-Computer-Desk-Adjustable-Executive-Leather-Arms/889963233?athbdg=L1600&adsRedirect=true.
2. Hover over the Fakespot address bar icon using the mouse cursor.

Expected result

• The Fakespot Address bar icon should be visible with High Contrast.

Actual result

• The Fakespot address bar icon has the same color when hovered over with High contrast enabled.

Regression range
Not Applicable

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:rdoghi, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Anna Yeddi [:ayeddi]]

Setting up the Accessibility Severity to S2, because the icon fully disappears with HCM on and thus the purpose of the control would not be communicated. This would especially affect users with cognitive difficulties, users with dyslexia, and neurodiverse users who may get confused about the purpose of the control they were going to activate.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:jhirsch, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

:ayeddi, assigning this to you, but let me know if you don't have bandwidth to pick it up

Comment 5

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1849554 - Updating Active Fakespot Address bar icon color on HCM. r=dao,desktop-theme-reviewers,jhirsch!

r=dao!,jhirsch!

Allowing the icon to keep the currentColor (which is expected to be
SelectedItemText) when the panel is opened and the icon is hovered on
HCM. This quick fix would resolve the active state issue with the opened
and hovered icon as well, while a wider styling solution for the chrome
controls on HCM is being developed.

Comment 6

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

[Tracking Requested - why for this release]: This is the only open accessibility s2 for the shopping experiment in 119. The fix is a very small CSS tweak (see patch) and we'd like to include it in 119.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef580bbd7972
Updating Active Fakespot Address bar icon color on HCM. r=desktop-theme-reviewers,dao,jhirsch

Comment 8

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

After discussion with :ayeddi and Ania, we do not need to uplift this into 120, as this same bug is considered accessibility s3 in other toolbar button bugs.

Comment 9

[Anna Yeddi [:ayeddi]]

Lowering the accessibility severity to S3 for consistency with the bug 1787934

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ef580bbd7972

Comment 11

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly build 120.0a1 (2023-10-06)