1854243 - Review checker URL bar icon disappears upon opting out

Status: VERIFIED FIXED

(Firefox :: Shopping, defect, P1)

Description

[Ania]

Pre-requisites: opt-into a Firefox experience, open up a PDP with the review checker sidebar.

Steps to reproduce

1. Opt out of the review checker via sidebar settings or by flipping a pref in about:config

Expected result

1. Review checker sidebar is closed and user is opted out, but its URL bar icon persists.
2. Upon clicking on the URL bar icon, the user is prompted to opt in again.

Actual result

1. URL bar icon is no longer available to the opted-out user.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Turns out we incorrectly disabled the urlbar button on opt out in bug 1849159. Duping this to that bug, which will now be reverted

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Hmm, I think I need this bug for the commit message. So I'll just mark bug 1849159 as causing this bug as a regression.

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1854243 - Do not hide sidebar shopping toolbar button on opt out. r?#shopping-reviewers

It turns out we should have closed bug 1849159 as invalid, because we do
not want to hide the shopping button if users opt out of the feature.
We want them to be able to try the feature again in the future.

This patch reverts the commit from bug 1849159.

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1854243 - Display shopping button even after opting out of the experiment. r?#shopping-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4095a9eb63f7
Display shopping button even after opting out of the experiment. r=shopping-reviewers,niklas

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4095a9eb63f7

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jhirsch, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox119 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 9355156 [details]
Bug 1854243 - Display shopping button even after opting out of the experiment. r?#shopping-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Users enrolled in the Nimbus experiment that opt out of the feature (either in the onboarding card or via the disable UI in the shopping sidebar) will not be able to try the feature again. Product wants to keep the sidebar button visible in the URLBar even after opting out, in case users want to try again.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: * Set browser.shopping.experience2023.enabled to true
• Set browser.shopping.experience2023.optedIn to 1
• Open a supported product page
• Go to the sidebar settings UI and click "Turn off review checker" button
• The urlbar button for shopping should still be visible after the sidebar is closed
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The shopping experiment will be limited to a very small Nimbus experiment in 119; this code will not run for users not in the experiment.
• String changes made/needed: No
• Is Android affected?: No

Comment 9

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly build 120.0a1 (2023-09-28). The Review checker icon remains as disabled in the address bar after we Turn it off from the Settings card. Enabling it will correctly show the onboarding card.

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/1a41a118193d

Comment 11

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

Comment on attachment 9355156 [details]
Bug 1854243 - Display shopping button even after opting out of the experiment. r?#shopping-reviewers

Approved for 119.0b3

Comment 12

[Rares Doghi, Desktop QA]

Verified as fixed in out latest Beta Build 119.0b3.
Tested with this build: https://treeherder.mozilla.org/jobs?repo=mozilla-beta&revision=1a41a118193dc3ad19c04b3da34ba9f08b5f4b2e&selectedTaskRun=aY848BgdSKOOfAxkoFp3nQ.1