Closed Bug 1849571 Opened 1 year ago Closed 1 year ago

A vertical scrollbar is displayed on the Fakespot Onboarding sidebar

Categories

(Firefox :: Messaging System, defect, P1)

Product:
Firefox
Component:
Messaging System
Version:
Firefox 118
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
119 Branch
Iteration:
119.1 - Aug 28 - Sept 8
Tracking Flags:
Tracking Status
firefox-esr102 --- disabled
firefox-esr115 --- disabled
firefox116 --- disabled
firefox117 --- disabled
firefox118 --- wontfix
firefox119 --- verified

People

(Reporter: atrif, Assigned: emcminn)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [omc])

Attachments

(2 files)

vertical_shoppping.gif
1.01 MB, image/gif
Details
Bug 1849571 - Match onboarding container height to content in shopping sidebar
48 bytes, text/x-phabricator-request
Details | Review
Attached image vertical_shoppping.gif —

Found in

  • 118.0a1 (2023-08-19)

Affected versions

  • 118.0a1 (2023-08-19)

Tested platforms

  • Affected platforms: Windows 10x64, macOS 12, Ubuntu 20
  • Unaffected platforms: none

Preconditions

  • browser.shopping.experience2023.enabled: true
  • browser.shopping.experience2023.optedIn: 0

Steps to reproduce

  1. Open the https://www.amazon.com/dp/B08D73C9FH link.

Expected result

  • Vertical scrollbar shouldn't be displayed without enough content.

Actual result

  • A vertical scrollbar is displayed even if it’s not necessary.

Regression range

  • Not Applicable. New feature.

Additional notes

  • Attached a screen recording.

:atrif, if you think that's a regression, could you try to find a regression range using for example mozregression?

Assignee: nobody → emcminn
Iteration: --- → 119.1 - Aug 28 - Sept 8
Priority: -- → P1
Blocks: fs-onboarding
Whiteboard: [omc]
Attachment #9350732 - Attachment description: Bug 1849571 - Remove scrollbar from onboarding container in shopping sidebar → Bug 1849571 - Match onboarding container height to content in shopping sidebar
Pushed by emcminn@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e0aeda87ea5b Match onboarding container height to content in shopping sidebar r=omc-reviewers,aminomancer

https://hg.mozilla.org/mozilla-central/rev/e0aeda87ea5b

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox119: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch

Verified as fixed in our latest Nightly 119.0a1 (2023-09-01) .

status-firefox119: fixed → verified

The patch landed in nightly and beta is affected.
:emcminn, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox118 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(emcminn)
status-firefox118: affected → wontfix
Flags: needinfo?(emcminn)
Duplicate of this bug: 1851659
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: