1851659 - [foxfooding] Review Quality Check welcome sidebar is unnecessarily scrollable (i.e. has scrollable blank space at the bottom) and scrolled to the bottom with content clipped at the top.

Status: VERIFIED DUPLICATE of bug 1849571

(Firefox :: Messaging System, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot

STR:

1. Enable the Review Quality Check feature.
2. Open a new Firefox window and visit some product page that triggers the feature e.g. this one
3. Immediately alt-tab away such that this^ newly-opened window is not visible.
4. Allow enough time to pass for the page to load, and then alt-tab back.

ACTUAL RESULTS:

• The Product Review Check sidebar has a scrollbar for no clear reason. (There's just blank space at the bottom)
• The scrollbar is automatically scrolled to the bottom, so I can't see the information at the top.

EXPECTED RESULTS:
No such scrollbar (unless there's actually overflowing content)
Scrollbar shouldn't be scrolled to the bottom.

Note: I only see this unexpected-scrollbar in my main browsing profile; I couldn't make it show up in a fresh profile. I'm not yet sure why, or what's needed to trigger this. My main profile has a handful of extensions and many many tabs open; it's possible that these may be factors that are relevant here.

Also: step 3 (alt-tabbing and covering up the window) seems to be important to triggering the "scrollbar automatically scroll to the bottom" issue. If I skip step 3, then I still see the unexpected scrollbar, but at least it automatically starts out at the top.

Comment 1

[Daniel Holbert [:dholbert]]

Note: I couldn't figure out how to get devtools active for this sidebar, to inspect the content at the bottom and find out what was creating that space. (I tried F12, but that only lets me inspect the actual page content; and I tried Browser Toolbox, but that only lets me inspect e.g. toolbar buttons; it won't let me target the sidebar. And the right-click context menu in the sidebar doesn't have an "Inspect" option.)

If anyone knows how to to get devtools active for the sidebar, let me know and I can poke around to find out more clues.

Comment 2

[Daniel Holbert [:dholbert]]

Hmm, after restarting Firefox, I wasn't able to reproduce this anymore.

If no one else can reproduce this, then maybe this can just be closed as WORKSFORME. I'll leave it open for now, though, in case anyone else hits the same issue and we can do further investigation.

Comment 3

[Emily McMinn :emcminn]

Hi Daniel, the extra scrollbar should have been fixed with https://bugzilla.mozilla.org/show_bug.cgi?id=1849571 - are you still able to reproduce on the latest Nightly? I haven't been able to, so if not we can close this as duplicate.

Comment 4

[Daniel Holbert [:dholbert]]

Thanks! Yes, it looks like this was a duplicate of bug 1849571. It looks like I filed it a few days after the fix for bug 1849571 landed, but it looks like it was the first day back at my work machine after a long holiday weekend, so I probably was on an old Nightly and hadn't yet restarted Firefox to accept the pending update.

That would explain why the issue went away in a fresh profile, and in my main profile after I restarted, too.

Comment 5

[Daniel Holbert [:dholbert]]

(Forgot to mention: I tested again with latest Nightly, and I can't reproduce, using my main browsing profile where I had initially seen this. In particular: I got myself back to the onboarding state by resetting browser.shopping.experience2023.optedIn, and then when seeing the onboarding UI, I wasn't able to trigger an unnecessary scrollbar or any weird blank space at the bottom.)