1849987 - Toggling map scopes on after pause is broken

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Hubert Boma Manilla (:bomsy)]

STR

1. Go to http://janodvarko.cz/tests/bugzilla/1759817/
2. Open the debugger
3. Make sure the map scopes is turned off
4. Click the Click Me button, this should cause the debugger to pause on line 11 in App.js
5. In the scopes panel check the map scopes button to toggle map scopes

BUG

This shows in the browser console TypeError: can't access property "includes", frameId is undefined
Also hovering over the sum function still shows undefined

Comment 1

[Hubert Boma Manilla (:bomsy)]

This looks like it regressed.

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1849987 - [devtools] Pass selectedFrame to getGeneratedFrameScope instead of currentThread r=#devtools-reviewers

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

This bug has been marked as a regression. Setting status flag for Nightly to affected.

Comment 4

[Donal Meehan [:dmeehan]]

:bomsy do you know the regressor, is it bug 1822310?

Comment 5

[Hubert Boma Manilla (:bomsy)]

Hi Donal, Yeah that's the regressor.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1822310

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9125d5c558ea
[devtools] Pass selectedFrame to getGeneratedFrameScope instead of currentThread r=devtools-reviewers,nchevobbe

Comment 8

[Cristina Horotan [:chorotan]]

Backed out changeset 9125d5c558ea (Bug 1849987) for causing dt failures at browser_dbg-sourcemapped-toggle.js

Backout: https://hg.mozilla.org/integration/autoland/rev/cd841f05f1287fd18e123ee5166d4523b92d1aa4

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=9125d5c558eab0d0c15ac0134d45fa2c4c4cf7f1&test_paths=devtools%2Fclient%2Fdebugger%2Ftest%2Fmochitest&selectedTaskRun=IzmB8MB3R_am5MrLNNzHtA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=427563293&repo=autoland&lineNumber=15797

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a06c1526b651
[devtools] Pass selectedFrame to getGeneratedFrameScope instead of currentThread r=devtools-reviewers,nchevobbe

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a06c1526b651

Comment 11

[Donal Meehan [:dmeehan]]

:bomsy please add a beta uplift request on this when ready.
Do you want to add release uplift request too, if it's safe to include in a dot release?

Comment 12

[Hubert Boma Manilla (:bomsy)]

Comment on attachment 9350133 [details]
Bug 1849987 - [devtools] Pass selectedFrame to getGeneratedFrameScope instead of currentThread r=#devtools-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Developers will likely see wrong scope information in some locations for sourcemapped files
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small javascript fix to pass the selected frame rather than the current thread
• String changes made/needed:
• Is Android affected?: Unknown

Comment 13

[Pascal Chevrel:pascalc]

Comment on attachment 9350133 [details]
Bug 1849987 - [devtools] Pass selectedFrame to getGeneratedFrameScope instead of currentThread r=#devtools-reviewers

Approved for 118.0b5, thanks.

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/43b3f94c8b2c

Comment 15

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/43b3f94c8b2c

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9350133 [details]
Bug 1849987 - [devtools] Pass selectedFrame to getGeneratedFrameScope instead of currentThread r=#devtools-reviewers

Approved for 117.0.1

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/fc7a0d120f29