Closed Bug 1849987 Opened 9 months ago Closed 9 months ago

Toggling map scopes on after pause is broken

Categories

(DevTools :: Debugger, defect, P2)

defect

Tracking

(firefox-esr102 unaffected, firefox-esr115 unaffected, firefox117 fixed, firefox118 fixed, firefox119 fixed)

RESOLVED FIXED
119 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox-esr115 --- unaffected
firefox117 --- fixed
firefox118 --- fixed
firefox119 --- fixed

People

(Reporter: bomsy, Assigned: bomsy)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [devtools:relnote])

Attachments

(1 file)

STR

  1. Go to http://janodvarko.cz/tests/bugzilla/1759817/
  2. Open the debugger
  3. Make sure the map scopes is turned off
  4. Click the Click Me button, this should cause the debugger to pause on line 11 in App.js
  5. In the scopes panel check the map scopes button to toggle map scopes
BUG

This shows in the browser console TypeError: can't access property "includes", frameId is undefined
Also hovering over the sum function still shows undefined

This looks like it regressed.

Keywords: regression
Assignee: nobody → hmanilla
Attachment #9350133 - Attachment description: WIP: Bug 1849987 - [devtools] Pass selectedFrame to getGeneratedFrameScope instead of currentThread → Bug 1849987 - [devtools] Pass selectedFrame to getGeneratedFrameScope instead of currentThread r=#devtools-reviewers
Status: NEW → ASSIGNED
Severity: -- → S3
Priority: -- → P2

This bug has been marked as a regression. Setting status flag for Nightly to affected.

:bomsy do you know the regressor, is it bug 1822310?

Flags: needinfo?(hmanilla)

Hi Donal, Yeah that's the regressor.

Flags: needinfo?(hmanilla)
Regressed by: 1822310

Set release status flags based on info from the regressing bug 1822310

Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9125d5c558ea
[devtools] Pass selectedFrame to getGeneratedFrameScope instead of currentThread r=devtools-reviewers,nchevobbe
Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a06c1526b651
[devtools] Pass selectedFrame to getGeneratedFrameScope instead of currentThread r=devtools-reviewers,nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch

:bomsy please add a beta uplift request on this when ready.
Do you want to add release uplift request too, if it's safe to include in a dot release?

Comment on attachment 9350133 [details]
Bug 1849987 - [devtools] Pass selectedFrame to getGeneratedFrameScope instead of currentThread r=#devtools-reviewers

Beta/Release Uplift Approval Request

  • User impact if declined: Developers will likely see wrong scope information in some locations for sourcemapped files
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small javascript fix to pass the selected frame rather than the current thread
  • String changes made/needed:
  • Is Android affected?: Unknown
Flags: needinfo?(hmanilla)
Attachment #9350133 - Flags: approval-mozilla-beta?

Comment on attachment 9350133 [details]
Bug 1849987 - [devtools] Pass selectedFrame to getGeneratedFrameScope instead of currentThread r=#devtools-reviewers

Approved for 118.0b5, thanks.

Attachment #9350133 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9350133 - Flags: approval-mozilla-release?

Comment on attachment 9350133 [details]
Bug 1849987 - [devtools] Pass selectedFrame to getGeneratedFrameScope instead of currentThread r=#devtools-reviewers

Approved for 117.0.1

Attachment #9350133 - Flags: approval-mozilla-release? → approval-mozilla-release+
Whiteboard: [devtools:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: