1850043 - Clean up tb-flatpak docker image

Status: RESOLVED FIXED

(Thunderbird :: Build Config, task)

Description

[Daniel Darnell [:dandarnell]]

This bug will serve as an umbrella for non-functional changes to clean up the tb-flatpak docker image.

Comment 1

[Daniel Darnell [:dandarnell]]

Attachment: Bug 1850043 - Remove deprecated Flatpak .desktop file. r=#thunderbird-build-system-reviewers

Comment 2

[Daniel Darnell [:dandarnell]]

Attachment: Bug 1850043 - Reorganize, clarify, and clean-up runme.sh. r=#thunderbird-build-system-reviewers

Depends on D193747

Comment 3

[Daniel Darnell [:dandarnell]]

Attachment: Bug 1850043 - Add clarifying comments to Dockerfile. r=#thunderbird-build-system-reviewers

Depends on D193748

Comment 4

[Daniel Darnell [:dandarnell]]

Attachment: Bug 1850043 - Unify file naming convention using underscores. r=#thunderbird-build-system-reviewers

Depends on D193749

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/690642bd6211
Remove deprecated Flatpak .desktop file. r=rjl
https://hg.mozilla.org/comm-central/rev/2139f388b58c
Reorganize, clarify, and clean-up runme.sh. r=rjl
https://hg.mozilla.org/comm-central/rev/83b336d32051
Add clarifying comments to Dockerfile. r=rjl
https://hg.mozilla.org/comm-central/rev/451f7a7373f6
Unify file naming convention using underscores. r=rjl

Comment 6

[Daniel Darnell [:dandarnell]]

Comment on attachment 9363841 [details]
Bug 1850043 - Remove deprecated Flatpak .desktop file. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
User impact if declined: N/A (this patch is to make Flatpak task patches easier)
Testing completed (on c-c, etc.): One week on c-c
Risk to taking this patch (and alternatives if risky): Very little, this patch is a non-functional change

Comment 7

[Daniel Darnell [:dandarnell]]

Comment on attachment 9363843 [details]
Bug 1850043 - Reorganize, clarify, and clean-up runme.sh. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
User impact if declined: N/A (this patch is to make Flatpak task patches easier)
Testing completed (on c-c, etc.): One week on c-c
Risk to taking this patch (and alternatives if risky): Very little, this patch is a non-functional change

Comment 8

[Daniel Darnell [:dandarnell]]

Comment on attachment 9363844 [details]
Bug 1850043 - Add clarifying comments to Dockerfile. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
User impact if declined: N/A (this patch is to make Flatpak task patches easier)
Testing completed (on c-c, etc.): One week on c-c
Risk to taking this patch (and alternatives if risky): Very little, this patch is a non-functional change

Comment 9

[Daniel Darnell [:dandarnell]]

Comment on attachment 9363846 [details]
Bug 1850043 - Unify file naming convention using underscores. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
User impact if declined: N/A (this patch is to make Flatpak task patches easier)
Testing completed (on c-c, etc.): One week on c-c
Risk to taking this patch (and alternatives if risky): Very little, this patch is a non-functional change

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9363846 [details]
Bug 1850043 - Unify file naming convention using underscores. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for beta

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9363841 [details]
Bug 1850043 - Remove deprecated Flatpak .desktop file. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for beta

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9363843 [details]
Bug 1850043 - Reorganize, clarify, and clean-up runme.sh. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for beta

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9363844 [details]
Bug 1850043 - Add clarifying comments to Dockerfile. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for beta

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 121.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/b574fc2666ed
https://hg.mozilla.org/releases/comm-beta/rev/9b10b5a3aa1f
https://hg.mozilla.org/releases/comm-beta/rev/732862d8bdbe
https://hg.mozilla.org/releases/comm-beta/rev/5162509dbf8b

Comment 15

[Daniel Darnell [:dandarnell]]

Comment on attachment 9363841 [details]
Bug 1850043 - Remove deprecated Flatpak .desktop file. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
User impact if declined: None to end user, but this patch makes uplifting Flatpak fixes much easier.
Testing completed (on c-c, etc.): comm-central and comm-beta
Risk to taking this patch (and alternatives if risky): Very low

Comment 16

[Daniel Darnell [:dandarnell]]

Comment on attachment 9363843 [details]
Bug 1850043 - Reorganize, clarify, and clean-up runme.sh. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
User impact if declined: None to end user, but this patch makes uplifting Flatpak fixes much easier.
Testing completed (on c-c, etc.): comm-central and comm-beta
Risk to taking this patch (and alternatives if risky): Very low

Comment 17

[Daniel Darnell [:dandarnell]]

Comment on attachment 9363844 [details]
Bug 1850043 - Add clarifying comments to Dockerfile. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
User impact if declined: None to end user, but this patch makes uplifting Flatpak fixes much easier.
Testing completed (on c-c, etc.): comm-central and comm-beta
Risk to taking this patch (and alternatives if risky): Very low

Comment 18

[Daniel Darnell [:dandarnell]]

Comment on attachment 9363846 [details]
Bug 1850043 - Unify file naming convention using underscores. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
User impact if declined: None to end user, but this patch makes uplifting Flatpak fixes much easier.
Testing completed (on c-c, etc.): comm-central and comm-beta
Risk to taking this patch (and alternatives if risky): Very low

Comment 19

[Wayne Mery (:wsmwk)]

Comment on attachment 9363841 [details]
Bug 1850043 - Remove deprecated Flatpak .desktop file. r=#thunderbird-build-system-reviewers

[Triage Comment]
approved for esr115

Comment 20

[Wayne Mery (:wsmwk)]

Comment on attachment 9363843 [details]
Bug 1850043 - Reorganize, clarify, and clean-up runme.sh. r=#thunderbird-build-system-reviewers

[Triage Comment]
approved for esr115

Comment 21

[Wayne Mery (:wsmwk)]

Comment on attachment 9363844 [details]
Bug 1850043 - Add clarifying comments to Dockerfile. r=#thunderbird-build-system-reviewers

[Triage Comment]
approved for esr115

Comment 22

[Wayne Mery (:wsmwk)]

Comment on attachment 9363846 [details]
Bug 1850043 - Unify file naming convention using underscores. r=#thunderbird-build-system-reviewers

[Triage Comment]
approved for esr115

Comment 23

[Rob Lemley [:rjl]]

Thunderbird 115.6.0:
https://hg.mozilla.org/releases/comm-esr115/rev/6c27de0a2aeb
https://hg.mozilla.org/releases/comm-esr115/rev/688585491ee4
https://hg.mozilla.org/releases/comm-esr115/rev/6454f13feb94
https://hg.mozilla.org/releases/comm-esr115/rev/3ee0ee51fca8

Comment 24

[Daniel Darnell [:dandarnell]]

Attachment: Bug 1850043 - Move redundant files from tb-flatpak Docker image to recipes directory. r=#thunderbird-build-system-reviewers

Comment 25

[Daniel Darnell [:dandarnell]]

Attachment: Bug 1850043 - Bring tb-flatpak Docker image more inline with tb-snap. r=#thunderbird-build-system-reviewers

Depends on D203351

Comment 26

[Daniel Darnell [:dandarnell]]

Attachment: Bug 1850043 - Bring tb-flatpak Docker image more inline with tb-snap. r=#thunderbird-build-system-reviewers

Depends on D203351

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9d6765a50e2d
Move redundant files from tb-flatpak Docker image to recipes directory. r=rjl

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a151831b85b7
Bring tb-flatpak Docker image more inline with tb-snap. r=rjl DONTBUILD

Comment 29

[Daniel Darnell [:dandarnell]]

Comment on attachment 9388877 [details]
Bug 1850043 - Move redundant files from tb-flatpak Docker image to recipes directory. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
User impact if declined: None
Testing completed (on c-c, etc.): on c-c and flatpak built on local machine
Risk to taking this patch (and alternatives if risky): low

Comment 30

[Daniel Darnell [:dandarnell]]

Comment on attachment 9392800 [details]
Bug 1850043 - Bring tb-flatpak Docker image more inline with tb-snap. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
User impact if declined: None
Testing completed (on c-c, etc.): on c-c and flatpak built on local machine
Risk to taking this patch (and alternatives if risky): low

Comment 31

[Wayne Mery (:wsmwk)]

Comment on attachment 9388877 [details]
Bug 1850043 - Move redundant files from tb-flatpak Docker image to recipes directory. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for beta

Comment 32

[Wayne Mery (:wsmwk)]

Comment on attachment 9392800 [details]
Bug 1850043 - Bring tb-flatpak Docker image more inline with tb-snap. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for beta

Comment 33

[Daniel Darnell [:dandarnell]]

Thunderbird 125.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/30abdc068f4e
https://hg.mozilla.org/releases/comm-beta/rev/06d0e6d0cb51

Comment 34

[Rob Lemley [:rjl]]

Comment on attachment 9363841 [details]
Bug 1850043 - Remove deprecated Flatpak .desktop file. r=#thunderbird-build-system-reviewers

We can revisit these 115 uplifts later - there's some dependency on the Snap packaging bug with the recipes folder, so those patches need to be identified.