1850139 - WPT css/css-grid/alignment/grid-content-alignment-second-pass-002.html fails in Firefox, due to needing a second pass to re-resolve grid-template-rows percent values

Status: RESOLVED DUPLICATE of bug 1481876

(Core :: Layout: Grid, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: testcase 1

We fail this WPT test:
https://wpt.fyi/results/css/css-grid/alignment/grid-content-alignment-second-pass-002.html

At least for the first subtest, the issue is that we're not honoring the percent-sized grid-template-rows value (expressed in the grid shorthand). Reduced testcase attached.

The percent size here is a bit tricky, since there's no explicit height on the container for the percent value to resolve against. It seems we need to do a second percent-resolving pass (as hinted by the name of the WPT test) after we've resolved an initial measurement for the height of the grid container.

STR with reduced testcase:

1. Load attached testcase.

EXPECTED RESULTS:
Mostly-lime rectangle with small strip of orange at the top.

ACTUAL RESULTS:
Fully orange rectangle, no lime visible.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Bug 1481876 fixed grid-content-alignment-second-pass-002.html.

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to Ting-Yu Lin [:TYLin] (PDT, UTC-7) from comment #1)

Bug 1481876 fixed grid-content-alignment-second-pass-002.html.

BTW, this doesn't show up on wpt.fyi currently, since we don't have layout.css.grid-multi-pass-track-sizing.enabled turned on by default yet.