1850281 - Negative attachment size allowed in “Share for files larger than”

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[`{third: "Beedell", first: "Roke"}`{.JSON5}]

Attachment: Depiction of the problem.

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/116.0

Steps to reproduce:

A negative attachment size allowed in the “Share for files larger than” preference input form.

Actual results:

https://discourse.mozilla.org/t/what-would-a-negative-size-attachment-be/122165?u=rokejulianlockhart.rymcmt

Expected results:

Surely a negative value shouldn't be allowed?

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1850281 - Prevent input of negative numbers for cloudFileThreshold. r=aleca

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2979ace5befc
Prevent input of negative numbers for cloudFileThreshold. r=aleca

Comment 3

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9350378 [details]
Bug 1850281 - Prevent input of negative numbers for cloudFileThreshold. r=aleca

[Approval Request Comment]
Minor CSS addition
Risk to taking this patch (and alternatives if risky): Very low

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9350378 [details]
Bug 1850281 - Prevent input of negative numbers for cloudFileThreshold. r=aleca

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 118.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/beebc812dedb

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9350378 [details]
Bug 1850281 - Prevent input of negative numbers for cloudFileThreshold. r=aleca

[Triage Comment]
Approved for esr115

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 115.2.3:
https://hg.mozilla.org/releases/comm-esr115/rev/ded932f4f923