1850295 - Failing WPTs for :user-valid and :user-invalid behavior with form submit and reset

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Thomas Wisniewski [:twisniewski]]

We are failing these two WPTs:

• https://master-dot-wptdashboard.appspot.com/results/css/selectors/user-valid.html
• https://master-dot-wptdashboard.appspot.com/results/css/selectors/user-invalid.html

It appears to be related to us not clearing user-interaction flags after submitting or resetting forms.

Comment 1

[Tim Nguyen :ntim]

This is now all defined at: https://html.spec.whatwg.org/#selector-user-invalid & https://html.spec.whatwg.org/#selector-user-valid

I think Firefox is just missing the form reset bit.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1850295 - Update :user-{valid,invalid} to follow the spec. r=smaug,edgar

(Modulo open spec issues linked in comments)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50e9acd83446
Update :user-{valid,invalid} to follow the spec. r=smaug

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7a792b71de6
Fix some mochitests I had missed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c6429882e32
Don't test ui-valid from test_required_attribute.html.
https://hg.mozilla.org/integration/autoland/rev/58a46eb6578c
Add a few UpdateValidityElementStates calls that were papered before.
https://hg.mozilla.org/integration/autoland/rev/20963fe5ea2c
Fix non-unified build.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88d0f25f7837
Fix two more mochitests that were relying on previous behavior.

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/50e9acd83446
https://hg.mozilla.org/mozilla-central/rev/b7a792b71de6
https://hg.mozilla.org/mozilla-central/rev/0c6429882e32
https://hg.mozilla.org/mozilla-central/rev/58a46eb6578c
https://hg.mozilla.org/mozilla-central/rev/20963fe5ea2c
https://hg.mozilla.org/mozilla-central/rev/88d0f25f7837