1850300 - Fix web protocol registration

Status: RESOLVED FIXED

(SeaMonkey :: Feed Discovery and Preview, defect)

Description

[Ian Neal]

If you try to register a protocol (for example at http://permission.site/) you get a message in the error console about notificationBox not being defined.

Comment 1

[Ian Neal]

Attachment: 1850300-feed-protocol-25318.patch

[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: cannot register protocol
Testing completed (on m-c, etc.): 2.53.18
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

This patch syncs up the registerProtocolHandler and registerContentHandlet code to the same level as Firefox version of the file:
https://hg.mozilla.org/releases/mozilla-esr60/file/479174108809b512f3e849c9e388dee4d5c69056/browser/components/feeds/src/WebContentConverter.js

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9350395 [details] [diff] [review]
1850300-feed-protocol-25318.patch

Works fine. It is actually not the feeds handler which is broken but the support for other protocols. This just ended up in feeds too. See bug 372441.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dc3513005ad0
Fix web protocol registration. r=frg

Comment 4

[[e-mail]]

(In reply to Ian Neal from comment #1)

Regression caused by (bug #): unknown
Bug 1730392, which put a stack between the browser and the notificationbox.
The old code was written to work with both tabbrowser and sidebar browsers (for bookmarks that open in a sidebar), not that anyone still uses that feature, if it even still exists...

Comment 5

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/8d25d44e9d098ba7a2ee5f1763724e872b5cfc74
Fix web protocol registration. r=frg a=frg

(for bookmarks that open in a sidebar),
Yes this feature is gone.