1850339 - The search bar is not properly displayed in the overflow menu if it’s placed on the toolbar and Firefox has reduced width

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

Found in

• 118.0a1 (2023-08-27)

Affected versions

• 118.0a1 (2023-08-27)
• 117.0
• 116.0.3

Tested platforms

• Affected platforms: Ubuntu 20, Windows 10x64, macOS 12
• Unaffected platforms: none

Preconditions

• Search bar placed on toolbar

Steps to reproduce

1. Set the browser to minimum width so that the search bar is automatically moved to the overflow menu.
2. Open the Overflow menu.

Expected result

• The search bar is correctly displayed.

Actual result

• Search bar has reduced width.

Regression range

• Last good revision: 34056df4e1d5f8a9d55691039de73456918c1bc1
  First bad revision: e08af0bae48c1f8d7f45ce9f285b7c6378653767
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=34056df4e1d5f8a9d55691039de73456918c1bc1&tochange=e08af0bae48c1f8d7f45ce9f285b7c6378653767

Additional notes

• Attached a screeshot.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1823791, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1850339 - Make searchbar styles for fixed overflow panel also apply to the dynamic ones. r=Gijs,dao

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a0cc349e731
Make searchbar styles for fixed overflow panel also apply to the dynamic ones. r=Gijs

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5a0cc349e731

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox118 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

I don't think this is severe enough.

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with 119.0a1 (2023-08-30) on Windows 10x64, macOS 12, and Ubuntu 22. The search bar has the correct width after following the steps from comment 0.