Closed Bug 1823791 Opened 2 years ago Closed 2 years ago

Flexible Spaces are taking more space in the toolbar than they used to

Categories

(Firefox :: Theme, defect, P2)

defect

Tracking

()

VERIFIED FIXED
113 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox111 --- unaffected
firefox112 --- unaffected
firefox113 --- verified

People

(Reporter: itiel_yn8, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

STR to demonstrate this:

  1. On latest Nightly, add the search bar next to the url bar, with flexible spaces surrounding them in both sides (so it will be [flexible-space][urlbar][searchbar][flexible-space])
  2. Sprinkle some toolbarbuttons after the second flexible space
  3. Now do the same to a pre-bug-1820534 Nightly, see that the flexible spaces take less space.

In my 24" monitor + 150% DPI, this actually causes a usability issue as the urlbar isn't wide enough to provide important url data, and dragging the splitter to widen it doesn't work, but that's a pre-existing issue.

Set release status flags based on info from the regressing bug 1820534

:emilio, since you are the author of the regressor, bug 1820534, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

This was effectively the previous behavior (where the default flex basis
was effectively the size of the searchbar with width: auto, rather
than the modern flexbox auto behavior which is max-content (and
unfortunately doesn't account for min-width).

When the searchbar is resized flex-basis: auto does exactly what we
want.

Assignee: nobody → emilio
Status: NEW → ASSIGNED

And flex-shrink: 0 to prevent the urlbar from shrinking.

I don't have a strong feeling on which approach is preferrable. Might lean for the second because it doesn't need to use custom properties, but you let me know, they should be effectively equivalent.

Flags: needinfo?(emilio)
Severity: -- → S4
Priority: -- → P2
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/06efcd8f9c0c Approach 2: Use width to set the flex-basis. r=dao,Gijs

Backed out for causing mochitest failures in browser_1795260_searchbar_overflow_toolbar.js

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Attachment #9324390 - Attachment description: Bug 1823791 - Approach 2: Use width to set the flex-basis. r=dao,gijs,itiel → Bug 1823791 - Use width to set the flex-basis of urlbar/searchbar. r=dao,Gijs
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e08af0bae48c Use width to set the flex-basis of urlbar/searchbar. r=dao,Gijs
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Attachment #9324389 - Attachment is obsolete: true
Depends on: 1827031
Regressions: 1827031
Flags: qe-verify+

Reproduced with Fx 113.0a1 (2023-03-21) on Windows 10.
Verified fixed with Fx 114.0a1 (2023-05-03) and Fx 113.0 on Windows 10 and Ubuntu 22.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Regressions: 1833318
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: