Flexible Spaces are taking more space in the toolbar than they used to
Categories
(Firefox :: Theme, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr102 | --- | unaffected |
firefox111 | --- | unaffected |
firefox112 | --- | unaffected |
firefox113 | --- | verified |
People
(Reporter: itiel_yn8, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
STR to demonstrate this:
- On latest Nightly, add the search bar next to the url bar, with flexible spaces surrounding them in both sides (so it will be [flexible-space][urlbar][searchbar][flexible-space])
- Sprinkle some toolbarbuttons after the second flexible space
- Now do the same to a pre-bug-1820534 Nightly, see that the flexible spaces take less space.
In my 24" monitor + 150% DPI, this actually causes a usability issue as the urlbar isn't wide enough to provide important url data, and dragging the splitter to widen it doesn't work, but that's a pre-existing issue.
Comment 1•2 years ago
|
||
Set release status flags based on info from the regressing bug 1820534
:emilio, since you are the author of the regressor, bug 1820534, could you take a look? Also, could you set the severity field?
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 2•2 years ago
|
||
This was effectively the previous behavior (where the default flex basis
was effectively the size of the searchbar with width: auto
, rather
than the modern flexbox auto behavior which is max-content (and
unfortunately doesn't account for min-width).
When the searchbar is resized flex-basis: auto does exactly what we
want.
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
And flex-shrink: 0 to prevent the urlbar from shrinking.
Assignee | ||
Comment 4•2 years ago
|
||
I don't have a strong feeling on which approach is preferrable. Might lean for the second because it doesn't need to use custom properties, but you let me know, they should be effectively equivalent.
Updated•2 years ago
|
Comment 6•2 years ago
|
||
Backed out for causing mochitest failures in browser_1795260_searchbar_overflow_toolbar.js
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_1795260_searchbar_overflow_toolbar.js | Searchbar shouldn't overflow -
Assignee | ||
Updated•2 years ago
|
Updated•2 years ago
|
Comment 8•2 years ago
|
||
bugherder |
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Comment 9•2 years ago
|
||
Reproduced with Fx 113.0a1 (2023-03-21) on Windows 10.
Verified fixed with Fx 114.0a1 (2023-05-03) and Fx 113.0 on Windows 10 and Ubuntu 22.
Description
•