1850602 - Add spinner to "analysis in progress" component

Status: VERIFIED FIXED

(Firefox :: Shopping, task, P1)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

It looks like the analysis in progress component landed with an info icon, not a spinner, but UX had asked for a spinner in the figma.

Let's find a spinner in tree somewhere and swap it in instead.

Comment 2

[kpatenio]

Attachment: Bug 1850602 - Add spinner to in-progress-analysis shopping-message-bar

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e69f779ab23f
Add spinner to in-progress-analysis shopping-message-bar r=shopping-reviewers,reusable-components-reviewers,desktop-theme-reviewers,amy,mstriemer

Comment 4

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_notificationbox.xhtml | notification image is set - got """", expected "url("chrome://global/skin/icons/info-filled.svg")"

Also these mochitests failures

• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/protocolhandler/test/browser/browser_registerProtocolHandler_notification.js | Uncaught exception in test bound - undefined - timed out after 50 tries.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/653e4bbb493d
Add spinner to in-progress-analysis shopping-message-bar r=shopping-reviewers,reusable-components-reviewers,desktop-theme-reviewers,amy,mstriemer

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/653e4bbb493d

Comment 7

[Peter Magyari (Desktop QA)]

Verified fixed using Firefox Nightly 119.0a1 (20230911091854) on Windows 10, MacOS 11.6 and Ubuntu 20.04.