1850610 - Onboarding bottom sheet should open to full height

Status: RESOLVED FIXED

(Fenix :: Shopping, defect, P1)

Description

[Chris Peterson [:cpeterson]]

Attachment: bottom_sheet_screenshot.png

The first time the "Review quality check" bottom sheet opens on my Moto G5 Plus, the "Yes, check review quality" button is partially cut off and the "NOT NOW" button is hidden off screen.

My Moto G5 Plus has a small display, 5.2" 1920 × 1080 px (424 ppi). I can't reproduce on my Samsung Galaxy A42, which has a display size of 6.6" 1600 × 720 px (266 ppi).

Device information

• Firefox version: 119.0a1
• Android device model: Moto G5 Plus
• Android OS version: Android 8.1.0

Comment 1

[Chris Peterson [:cpeterson]]

Having to scroll the bottom sheet isn't a problem in general. It's only a problem the first time because the opt-in sheet's "Yes" button is visible but the "NOT NOW" button is hidden off screen.

Comment 2

[Noah Bond [:007]]

So to confirm, for this instance of a "first run" + opt-in, we want the sheet fully expanded? What we see in the screenshot is a default behavior of a component we're using and it shouldn't be a big lift; I just want to make sure we capture the right flow chart of logic with the expansion for the opt-in state.

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Noah Bond [:007] from comment #2)

So to confirm, for this instance of a "first run" + opt-in, we want the sheet fully expanded? What we see in the screenshot is a default behavior of a component we're using and it shouldn't be a big lift; I just want to make sure we capture the right flow chart of logic with the expansion for the opt-in state.

Verdi says:

• The opt-in sheet should expand to its full height.
• After that, the sheet should open only half height for review checks.

Comment 4

[Chris Peterson [:cpeterson]]

Attachment: landscape_bottom_sheet.png

A related issue: when I open the sheet in landscape orientation, it only shows the "Review quality check" title bar until you drag to expand the sheet. Verdi says the sheet should follow the same rules in landscape orientation: the opt-in sheet should expand to its full height and, after that, the sheet should open only half height for review checks.

Also, when the sheet's title bar is displayed in landscape orientation, a bright white bar flashes under the system navigation buttons.

Comment 5

[Anna Yeddi [:ayeddi]]

Attachment: TalkBack-is-announcing-Yes-button-but-focus-indication-is-not-visible-too.png

Assigning accessibility severity S3 because it may be unclear for users of assistive technology with cognitive difficulties and those TalkBack users who can see the screen (i.e. users with low vision) that there is something provided below the image, for example, Universal Switch users may not know that they could, in fact, scroll the view.

Screenshot was taken with Samsung Galaxy A54

Comment 6

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1850610 - Fix review checker onboarding bottom sheet height (#3814)

Comment 7

[BMO Github Automation]

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/e4a1d792c6be4294fbb6c578bef7ba452dba8228
[main] Bug 1850610 - Fix review checker onboarding bottom sheet height

Comment 8

[Adina Petridean QA [:apetridean]]

Verified as fixed on Nightly 120.0a1 from 09/29 with Google Pixel 7 Pro ( Android 14) and Motorola Moto G9 plus (Android 11). However, after further investigation, we observed that this issue is still reproducible on devices running Android versions below 9. We'll open a new ticket for this (https://bugzilla.mozilla.org/show_bug.cgi?id=1855966).

Comment 9

[Adina Petridean QA [:apetridean]]

Attachment: buttom.mp4

Comment 10

[Verdi [:verdi] Best to slack me]

Attachment: Screenshot 2023-10-09 at 9.57.22 AM.png

This still doesn't implement the full screen sheet. https://m2.material.io/components/sheets-bottom#behavior

Comment 11

[Verdi [:verdi] Best to slack me]

More explanation - https://drive.google.com/file/d/1COmwbExb6oGW7xxf33Xw-MDsaW_nBuBk/view?usp=drive_link

Comment 12

[Rahul Sainani [:rsainani]]

This was a different bug about opening the bottom sheet to show the buttons and fix an accessibility issue. See Bug 1858070 for full screen bottom sheet behavior with sticky header. Closing this in the favor of that.