1850631 - Remove default agent commands to set system defaults

Status: RESOLVED FIXED

(Toolkit :: Default Browser Agent, task, P3)

Description

[Nick Rishel [:nrishel]]

Now that the default browser agent is being rewritten as a background task it no longer makes sense to manually call it as a separate process when setting system defaults via Firefox.

Succinctly, we should:

1. Remove set-default-browser-user-choice and set-default-extension-handlers-user-choice commands from the default agent.
2. Modify the existing code in Firefox which invokes the default agent to set defaults to instead do the task in Firefox directly.
3. Optional cleanup, setting system default should likely be handled in our shell XPCOM APIs, and the default agent should use them instead of said logic existing in the default agent.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1850631 - Call nsIDefaultAgent directly to set default. r?nrishel

Comment 2

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

As this rolls out we'll want to monitor https://glam.telemetry.mozilla.org/firefox/probe/browser_set_default_user_choice_result/explore?activeBuckets=%5B%22Success%22%2C%22ErrProgID%22%2C%22ErrHash%22%2C%22ErrLaunchExe%22%2C%22ErrOther%22%2C%22ErrExeTimeout%22%2C%22ErrExeProgID%22%2C%22ErrExeHash%22%2C%22ErrExeRejected%22%2C%22ErrExeOther%22%5D&currentPage=1&os=Windows&process=parent&timeHorizon=QUARTER, but it doesn't seem to have Nightly data. (It does have Beta and Release.) We might need to do this "by hand" for Nightly data.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/daceab96e958
Call nsIDefaultAgent directly to set default. r=nrishel,nalexander

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/daceab96e958

Comment 5

[Nick Rishel [:nrishel]]

Attachment: Backed out changeset daceab96e958 (Bug 1850631)

Backed out due to changes breaking both Default Agent telemetry and launching Firefox in response to interaction with the Default Agent notifications.

Depends on D190867

Comment 6

[Donal Meehan [:dmeehan]]

Backed out of beta for Fx119
https://hg.mozilla.org/releases/mozilla-beta/rev/872df54b0643696850f2e31af2b3bff59e7f156a