1851596 - [win11] The make default button only works for the first time on one machine only

Status: VERIFIED FIXED

(Firefox :: Shell Integration, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: error_default.gif

Found in

• 118.0b4

Affected versions

• 119.0a1 (2023-09-04)
• 118.0b4
• 117.0
• 115.2esr

Tested platforms

• Affected platforms: Windows 11x64
• Unaffected platforms: macOS 13, Ubuntu 22.1, Windows 10x64

Preconditions

• Firefox is not the default browser.

Steps to reproduce

1. Open the Preferences page and click on the Make Default button.
2. Close the newly opened window.
3. Click on the Make Default button again.

Expected result

• The Default Apps window is opened again.

Actual result

• Nothing happens. Error: WDBA nonzero exit code 2147500037: ErrExeOther ShellService.sys.mjs:567:5 error is displayed in the browser console.

Regression range

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3bf5fce9130e653bffa77a8ef6119df92b27f6b7&tochange=e75a7ce5891f5c15e15f201ecfd816aaedf442c6

Additional notes

• I have Windows 22H2 (OS Build 22621.2215) Insider Release Preview.
• We tried on two Windows 11 machines with the same version. It seems that only this station is affected for some reason.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:barret, since you are the author of the regressor, bug 1805509, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox117 (release), tracked for firefox118 (beta) and tracked for firefox119 (nightly). However, the bug still isn't assigned and has low severity.

:lsmith, could you please find an assignee and increase the severity for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 3

[Beth Rennie [:beth] (she/her)]

Can you open regedit.exe and look at the following registry keys:

Computer\HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\FileExts\.htm
Computer\HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\FileExts\.html
Computer\HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\Shell\Associations\UrlAssociations\http\UserChoice
Computer\HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\Shell\Associations\UrlAssociations\http\UserChoice

Right click on the key in the sidebar and select permissions and see if any of these keys are missing permissions for your user. This happened to me when working on the feature, but I was never able to reproduce.

Deleting any key that is missing permissions for your user (you may have to open regedit as an admin) and then re-setting Firefox as default should fix the issue.

If none of this is the case, please let me know.

Comment 4

[Beth Rennie [:beth] (she/her)]

Redirecting to Firefox :: Shell Integration because this is a problem with the underlying implementation.

Comment 5

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to Barret Rennie [:barret] (they/them) from comment #3)

Can you open regedit.exe and look at the following registry keys:

Computer\HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\FileExts\.htm
Computer\HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\FileExts\.html
Computer\HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\Shell\Associations\UrlAssociations\http\UserChoice
Computer\HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\Shell\Associations\UrlAssociations\http\UserChoice

Right click on the key in the sidebar and select permissions and see if any of these keys are missing permissions for your user. This happened to me when working on the feature, but I was never able to reproduce.

Deleting any key that is missing permissions for your user (you may have to open regedit as an admin) and then re-setting Firefox as default should fix the issue.

If none of this is the case, please let me know.

Hello! I deleted all the registry keys from above and then clicked the Make Default button then the default apps windows application will open as expected, but closing it and clicking again the Make Default button will lead me to the same stage as before. I'm also seeing this error in browser console aside from the error stated in comment 0 after deleting the registry keys:
Error: checkBrowserUserChoiceHashes() failed setAsDefaultUserChoice resource:///modules/ShellService.sys.mjs:286 setDefaultBrowser resource:///modules/ShellService.sys.mjs:376 setDefaultBrowser chrome://browser/content/preferences/main.js:1729 ShellService.sys.mjs:377:17 setDefaultBrowser resource:///modules/ShellService.sys.mjs:377

I have also created a new Windows Administrator online profile and it seems that the issue is reproducing there as well.
Note: I can successfully set Firefox as the default browser if I manually open the Default Apps window and select Firefox for HTTP/HTTPS, .htm/.html. If more information is needed please let me know.

Comment 6

[Masatoshi Kimura [:emk]]

(In reply to Alexandru Trif, Desktop QA [:atrif] from comment #0)

• Nothing happens. Error: WDBA nonzero exit code 2147500037: ErrExeOther ShellService.sys.mjs:567:5 error is displayed in the browser console.

This error is swallowed here because _handleWDBAResult() is an async function and callers do not await the returned promise.

setAsDefaultUserChoice() and setAsDefaultPDFHandlerUserChoice() should await _handleWDBAResult() to handle exceptions from _handleWDBAResult().

Comment 7

[Masatoshi Kimura [:emk]]

This changeset introduced the bug. The changeset converted a code block to a function call, but it forgot to await the returned promise.

Comment 8

[Masatoshi Kimura [:emk]]

Attachment: Bug 1851596 - await _handleWDBAResult. r?nalexander

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df18c9cb1487
await _handleWDBAResult. r=nalexander

Comment 10

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest failure on browser_setDefaultBrowser.js

Backout link

Push with failures

Failure log

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ef7b4209835
await _handleWDBAResult. r=nalexander

Comment 12

[Masatoshi Kimura [:emk]]

Currently fallbacks do not work at all due to changes from bug 1838754. WDBA proxy does not propagate errors from background tasks.

Comment 13

[Masatoshi Kimura [:emk]]

Attachment: Bug 1851596 - Propagate return code from the child process. r?nalexander

Comment 14

[Masatoshi Kimura [:emk]]

Attachment: Bug 1851596 - Propagate exit codes from background tasks. r?nalexander

Comment 15

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/3ef7b4209835

Comment 16

[Phabricator Automation]

Comment on attachment 9352374 [details]
Bug 1851596 - Propagate exit codes from background tasks. r?nalexander

Revision D187848 was moved to bug 1852500. Setting attachment 9352374 [details] to obsolete.

Comment 17

[Masatoshi Kimura [:emk]]

I moved D187848 to bug 1852500 to make this bug uplift-able.

Comment 18

[Masatoshi Kimura [:emk]]

Comment on attachment 9352363 [details]
Bug 1851596 - await _handleWDBAResult. r?nalexander

Beta/Release Uplift Approval Request

• User impact if declined: "Make Default" button will not work if one-click-default fails for some reason.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Correctness fix, only affects the fallback behavior.
• String changes made/needed: none
• Is Android affected?: No

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Microsoft may change the user choice hash algorithm any time. It will break "Make Default" functionarity retrospective.
• User impact if declined: "Make Default" button will not work if one-click-default fails for some reason.
• Fix Landed on Version: 119
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Correctness fix, only affects the fallback behavior.

Comment 19

[Masatoshi Kimura [:emk]]

Attachment: Bug 1851596 - Skip test on platforms earlier than Windows 10. r=test-only

Since ESR 115 still supprts Windows 7/8.1, we have to skip the test on
thos platforms.

Comment 20

[Masatoshi Kimura [:emk]]

Comment on attachment 9352445 [details]
Bug 1851596 - Skip test on platforms earlier than Windows 10. r=test-only

See comment #18 for ESR Uplift Approval Request.

Since ESR 115 still supports Windows 7/8.1, we have to skip the test on those platforms.

Comment 21

[Pascal Chevrel:pascalc]

Comment on attachment 9352363 [details]
Bug 1851596 - await _handleWDBAResult. r?nalexander

Approved for 118.0b8, thanks.

Comment 22

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/c5a027a0b61a

Comment 23

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/c5a027a0b61a

Comment 24

[Pascal Chevrel:pascalc]

Comment on attachment 9352363 [details]
Bug 1851596 - await _handleWDBAResult. r?nalexander

Approved for ESR 115.3, thanks.

Comment 25

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/caeab8f0f9ea
https://hg.mozilla.org/releases/mozilla-esr115/rev/9755b5fb1c6f

Comment 26

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-esr115/rev/caeab8f0f9ea
https://hg.mozilla.org/releases/mozilla-esr115/rev/9755b5fb1c6f

Comment 27

[Masatoshi Kimura [:emk]]

Nightly also requires a fix in bug 1850631.

Comment 28

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello! Unfortunately, I don't have the same Windows version on my machine (OS Build 22621.2215) because I updated it.

I could reproduce the issue on Windows 11x64 22H2 (22621.2361) with Firefox 119.0a1 (2023-09-11). The Make default button opens the "Default Apps" settings only for the first time when clicked and does nothing after closing the Default Apps window and clicking it again.

This issue (Make default button does not work a second time) is verified fixed with Firefox 115.3.1esr, 118.0.1, and 119.0b3 on the same Windows 11 machine. The Make default button now opens the "Default apps" settings each time the button is clicked.

Note: An error is displayed when clicking the Make default button and the one-click-make-default feature does not work. This issue is investigated in bug 1852412. Closing this issue as verified since the original issue could be reproduced on this Windows version as well.