1850649 - Close button on active narrow tab missing in latest nightly

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Albert Scheiner [:alberts]]

Attachment: missing-closing-x-on-active-tab.png

When opening enough tabs, the closing "X" eventually disappears even from the active tab.
Firefox 119.0a1 (2023-08-29)
macOS 12.6.8 and 13.4

Checking beta Firefox 118.0b2 and stable 117, when tabs get narrow enough, all closing "X" disappear, except of for the currently active tab.

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0e326fb37f8cfe18e25428a3e28ace064b1cb756&tochange=413e4650af9aec2a62cb9b3d2f4ea55d1a220805

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1849904

:dao, since you are the author of the regressor, bug 1849904, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Kiran]

(In reply to Albert Scheiner [:alberts] from comment #0)

Created attachment 9350760 [details]
missing-closing-x-on-active-tab.png

When opening enough tabs, the closing "X" eventually disappears even from the active tab.
Firefox 119.0a1 (2023-08-29)
macOS 12.6.8 and 13.4

Checking beta Firefox 118.0b2 and stable 117, when tabs get narrow enough, all closing "X" disappear, except of for the currently active tab.

I see the issue too on Firefox 119.0a1 (2023-08-29) (64-bit), Windows 11.
There are no close buttons, once the number of tabs is above 11 tabs on my laptop. The active tab and inactive tabs lose the close button. The tabs can be closed with CTRL+W keyboard shortcut though.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox119 (nightly). However, the bug still isn't assigned.

:cbellini, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

This is pretty annoying. Dao, can we get the regressor backed out from m-c and new nightlies spun?

Comment 8

[Dão Gottwald [:dao]]

Attachment: Bug 1850649 - Treat the 'selected' attribute (which is an alias for 'visuallyselected' here) as a standard boolean attribute. r=mak

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/c4e74daae186
Treat the 'selected' attribute (which is an alias for 'visuallyselected' here) as a standard boolean attribute. r=mak a=Aryx

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c4e74daae186

Comment 14

[Giorgia Nichita, Release Desktop QA]

Reproduced the issue on an affected Nightly build from 2023-08-29, on Windows 11.
Verified as fixed on Firefox 119.0b4 (20231002091755) on Win 11, macOS 12 and macOS 13.