1850826 - Refactor LegalParagraph as LinkParagraph & replace usage of cta_paragraph in shopping sidebar onboarding

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Emily McMinn :emcminn]

As discussed in https://phabricator.services.mozilla.com/D186579; we should repurpose the LegalParagraph component to cover the use of cta_paragraph in the shopping onboarding message - this can be worked on once https://phabricator.services.mozilla.com/D186499 lands.

Comment 1

[Punam Dahiya [:pdahiya]]

With Bug 1847641 fix in Nightly, we can remove cta_paragraph and use array of text to display second paragraph text something like below in JSON:

above_button_content: [ { type: "text", text: { string_id: "shopping-onboarding-body", }, link_keys: ["learn_more_link"], }, { type: "image", url: "chrome://browser/content/shopping/assets/temp-fakespot-rating.svg", height: "auto", }, { type: "text", text: { string_id: "shopping-onboarding-opt-in-privacy-policy-and-terms-of-use", }, link_keys: ["privacy_policy", "terms_of_use"], }, ], learn_more_link: { action: { type: "OPEN_URL", data: { args: "https://www.support.mozilla.org", where: "tab", }, }, }, privacy_policy: { action: { type: "OPEN_URL", data: { args: "https://www.fakespot.com/privacy-policy", where: "tab", }, }, }, terms_of_use: { action: { type: "OPEN_URL", data: { args: "https://www.fakespot.com/terms", where: "tab", }, }, },

There will be small code change to make LegalParagraph pick style from JSON config that is show text as 'regular' or 'legal' with regular text styled with default
font-size: 0.8em; color: #5B5B66;

and .welcome-text margins adjusted as per shopping figma. This should resolve Bug 1850924

Comment 2

[Negin Sauermann]

Attachment: Bug 1850826 - Refactor LegalParagraph as LinkParagraph & replace usage of cta_paragraph in shopping sidebar onboarding

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/695253c15da8
Refactor LegalParagraph as LinkParagraph & replace usage of cta_paragraph in shopping sidebar onboarding r=omc-reviewers,pdahiya,fluent-reviewers,flod,shopping-reviewers,Gijs

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/695253c15da8

Comment 6

[Peter Magyari (Desktop QA)]

Verified fixed using Firefox Nightly 119.0a1 (20230925093027) on Windows 10, MacOS 11 and Ubuntu 20.04.