1853979 - Intermittent browser/components/shopping/tests/browser/browser_shopping_onboarding.js | single tracking bug

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: csabou [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=429691749&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/VS8V6j8WTEO2FwpKRzsMgA/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/VS8V6j8WTEO2FwpKRzsMgA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2023-09-19T16:37:21.720Z] 16:37:21     INFO - TEST-PASS | browser/components/shopping/tests/browser/browser_shopping_onboarding.js | multi-stage-message-slot showing opt-in message rendered - "multi-stage-message-slot" == "multi-stage-message-slot" - 
[task 2023-09-19T16:37:21.721Z] 16:37:21     INFO - Buffered messages finished
[task 2023-09-19T16:37:21.724Z] 16:37:21     INFO - TEST-UNEXPECTED-FAIL | browser/components/shopping/tests/browser/browser_shopping_onboarding.js | message is shown - false == true - got false, expected true (operator ==)
[task 2023-09-19T16:37:21.725Z] 16:37:21     INFO - Stack trace:
[task 2023-09-19T16:37:21.725Z] 16:37:21     INFO - ok@resource://testing-common/SpecialPowersSandbox.sys.mjs:85:21
[task 2023-09-19T16:37:21.726Z] 16:37:21     INFO - @chrome://mochitests/content/browser/browser/components/shopping/tests/browser/browser_shopping_onboarding.js:128:11
[task 2023-09-19T16:37:21.726Z] 16:37:21     INFO - async*execute@resource://testing-common/SpecialPowersSandbox.sys.mjs:139:12
[task 2023-09-19T16:37:21.727Z] 16:37:21     INFO - _spawnTask@resource://testing-common/SpecialPowersChild.sys.mjs:1654:15
[task 2023-09-19T16:37:21.728Z] 16:37:21     INFO - receiveMessage@resource://testing-common/SpecialPowersChild.sys.mjs:257:21
[task 2023-09-19T16:37:21.728Z] 16:37:21     INFO - JSActor query*receiveMessage@resource://testing-common/SpecialPowersParent.sys.mjs:1385:14
[task 2023-09-19T16:37:21.729Z] 16:37:21     INFO - JSActor query*spawn@resource://testing-common/SpecialPowersChild.sys.mjs:1583:17
[task 2023-09-19T16:37:21.730Z] 16:37:21     INFO - test_showOnboarding_notOptedIn/<@chrome://mochitests/content/browser/browser/components/shopping/tests/browser/browser_shopping_onboarding.js:108:27
[task 2023-09-19T16:37:21.731Z] 16:37:21     INFO - withNewTab@resource://testing-common/BrowserTestUtils.sys.mjs:146:22
[task 2023-09-19T16:37:21.731Z] 16:37:21     INFO - async*test_showOnboarding_notOptedIn@chrome://mochitests/content/browser/browser/components/shopping/tests/browser/browser_shopping_onboarding.js:95:26
[task 2023-09-19T16:37:21.732Z] 16:37:21     INFO - handleTask@chrome://mochikit/content/browser-test.js:1131:26
[task 2023-09-19T16:37:21.733Z] 16:37:21     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1203:18
[task 2023-09-19T16:37:21.735Z] 16:37:21     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1345:14
[task 2023-09-19T16:37:21.735Z] 16:37:21     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1120:14
[task 2023-09-19T16:37:21.736Z] 16:37:21     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2023-09-19T16:37:21.737Z] 16:37:21     INFO - Leaving test bound test_showOnboarding_notOptedIn
[task 2023-09-19T16:37:21.738Z] 16:37:21     INFO - Entering test bound test_hideOnboarding_optedIn
[task 2023-09-19T16:37:23.399Z] 16:37:23     INFO - TEST-PASS | browser/components/shopping/tests/browser/browser_shopping_onboarding.js | message is hidden - true == true - 

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:nsauermann, since you are the author of the regressor, bug 1850826, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1850826

Comment 3

[Intermittent Failures Robot]

1 failures in 3850 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• linux1804-64-tsan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1853979&startday=2023-09-18&endday=2023-09-24&tree=all

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1850826

Comment 5

[Serban Stanca [:SerbanS]]

Tier 1 failure, link here.

Comment 6

[Intermittent Failures Robot]

5 failures in 4018 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3
• try: 1
• mozilla-central: 1

Platform and build breakdown:

• linux1804-64-asan-qr: 5
  • opt: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1853979&startday=2023-10-02&endday=2023-10-08&tree=all

Comment 7

[Intermittent Failures Robot]

15 failures in 3764 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 13
• mozilla-central: 1
• try: 1

Platform and build breakdown:

• windows11-64-2009-asan-qr: 1
  • opt: 1
• linux1804-64-asan-qr: 14
  • opt: 14

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1853979&startday=2023-10-09&endday=2023-10-15&tree=all

Comment 8

[Intermittent Failures Robot]

23 failures in 3484 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 13
• try: 3
• mozilla-central: 6
• elm: 1

Platform and build breakdown:

• linux1804-64-asan-qr: 16
  • opt: 16
• linux1804-64-qr: 6
  • debug: 6
• windows11-64-2009-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1853979&startday=2023-10-16&endday=2023-10-22&tree=all

Comment 9

[Intermittent Failures Robot]

21 failures in 706 pushes (0.03 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 9
• mozilla-beta: 3
• mozilla-central: 5
• try: 4

Platform and build breakdown:

• linux1804-64-qr: 15
  • debug: 15
• linux1804-64-asan-qr: 6
  • opt: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1853979&startday=2023-10-24&endday=2023-10-24&tree=all

Comment 10

[Intermittent Failures Robot]

15 failures in 638 pushes (0.024 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-beta: 6
• mozilla-central: 2
• autoland: 7

Platform and build breakdown:

• linux1804-64-qr: 7
  • debug: 7
• linux1804-64-asan-qr: 8
  • opt: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1853979&startday=2023-10-27&endday=2023-10-27&tree=all

Comment 11

[Intermittent Failures Robot]

62 failures in 3657 pushes (0.017 failures/push) were associated with this bug in the last 7 days.

This is the #21 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-central: 12
• mozilla-beta: 18
• autoland: 27
• try: 5

Platform and build breakdown:

• windows11-64-2009-qr: 2
  • debug: 2
• linux1804-64-asan-qr: 28
  • opt: 28
• linux1804-64-qr: 30
  • debug: 30
• macosx1015-64-qr: 1
  • debug: 1
• windows11-64-2009-devedition-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1853979&startday=2023-10-23&endday=2023-10-29&tree=all

Comment 12

[Iulian Moraru]

Update:
There have been 41 failures within the last 7 days:
• 20 failures on Linux 18.04 x64 WebRender asan opt
• 21 failures on Linux 18.04 x64 WebRender debug
The failure that is happening the most here, is TEST-UNEXPECTED-FAIL | browser/components/shopping/tests/browser/browser_shopping_onboarding.js | Uncaught exception in test bound test_showOnboarding_notOptedIn - at chrome://mochitests/content/browser/browser/components/shopping/tests/browser/browser_shopping_onboarding.js:144 - TypeError: can't access property "length", events is null
Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=434363770&repo=autoland&lineNumber=18473

[task 2023-10-30T23:53:47.969Z] 23:53:47     INFO - TEST-PASS | browser/components/shopping/tests/browser/browser_shopping_onboarding.js | message is shown - true == true - 
[task 2023-10-30T23:53:47.969Z] 23:53:47     INFO - Buffered messages finished
[task 2023-10-30T23:53:47.970Z] 23:53:47     INFO - TEST-UNEXPECTED-FAIL | browser/components/shopping/tests/browser/browser_shopping_onboarding.js | Uncaught exception in test bound test_showOnboarding_notOptedIn - at chrome://mochitests/content/browser/browser/components/shopping/tests/browser/browser_shopping_onboarding.js:144 - TypeError: can't access property "length", events is null
[task 2023-10-30T23:53:47.971Z] 23:53:47     INFO - Stack trace:
[task 2023-10-30T23:53:47.972Z] 23:53:47     INFO - test_showOnboarding_notOptedIn@chrome://mochitests/content/browser/browser/components/shopping/tests/browser/browser_shopping_onboarding.js:144:20
[task 2023-10-30T23:53:47.972Z] 23:53:47     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1134:26
[task 2023-10-30T23:53:47.973Z] 23:53:47     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1206:18
[task 2023-10-30T23:53:47.974Z] 23:53:47     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1348:14
[task 2023-10-30T23:53:47.975Z] 23:53:47     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1123:14
[task 2023-10-30T23:53:47.976Z] 23:53:47     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2023-10-30T23:53:47.978Z] 23:53:47     INFO - Leaving test bound test_showOnboarding_notOptedIn
[task 2023-10-30T23:53:47.979Z] 23:53:47     INFO - Entering test bound test_hideOnboarding_optedIn
[task 2023-10-30T23:53:47.980Z] 23:53:47     INFO - GECKO(10069) | [Child 10279: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f4d97aed800 == 3 [pid = 10279] [id = 19]
[task 2023-10-30T23:53:47.981Z] 23:53:47     INFO - GECKO(10069) | [Child 10279: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 26 (7f4d97a206a0) [pid = 10279] [serial = 58] [outer = 0]
[task 2023-10-30T23:53:47.982Z] 23:53:47     INFO - GECKO(10069) | [Child 10279: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 27 (7f4d98db1000) [pid = 10279] [serial = 59] [outer = 7f4d97a206a0]
[task 2023-10-30T23:53:47.984Z] 23:53:47     INFO - GECKO(10069) | [Child 10279, Main Thread] WARNING: IPC message 'PSessionStore::Msg_SessionStoreUpdate' discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:545
[task 2023-10-30T23:53:47.985Z] 23:53:47     INFO - GECKO(10069) | [Child 10279: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 28 (7f4d98db6000) [pid = 10279] [serial = 60] [outer = 7f4d97a206a0]
[task 2023-10-30T23:53:47.986Z] 23:53:47     INFO - GECKO(10069) | console.error: "Failed to fetch product analysis data" (new Error("request failed", "resource:///actors/ShoppingSidebarChild.sys.mjs", 290))
[task 2023-10-30T23:53:47.988Z] 23:53:47     INFO - GECKO(10069) | [Child 10279, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, NS_OK) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/caps/BasePrincipal.cpp:1150
[task 2023-10-30T23:53:47.989Z] 23:53:47     INFO - GECKO(10069) | [Child 10279, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, NS_OK) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/caps/BasePrincipal.cpp:1150
[task 2023-10-30T23:53:48.383Z] 23:53:48     INFO - GECKO(10069) | [Child 10279: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7f4d98dbb000 == 2 [pid = 10279] [id = 18] [url = about:shoppingsidebar]
[task 2023-10-30T23:53:48.385Z] 23:53:48     INFO - GECKO(10069) | [Child 10279: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 27 (7f4d98db5c00) [pid = 10279] [serial = 33] [outer = 0] [url = about:privatebrowsing]
[task 2023-10-30T23:53:48.386Z] 23:53:48     INFO - GECKO(10069) | [Child 10279: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 26 (7f4d98dba400) [pid = 10279] [serial = 36] [outer = 0] [url = about:shoppingsidebar]
[task 2023-10-30T23:53:48.388Z] 23:53:48     INFO - GECKO(10069) | [Child 10279: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 25 (7f4d98db5400) [pid = 10279] [serial = 38] [outer = 0] [url = about:blank]
[task 2023-10-30T23:53:48.389Z] 23:53:48     INFO - GECKO(10069) | [Child 10279: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 24 (7f4d98238800) [pid = 10279] [serial = 41] [outer = 0] [url = about:blank]
[task 2023-10-30T23:53:48.390Z] 23:53:48     INFO - GECKO(10069) | [Child 10279: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 23 (7f4d99cb6800) [pid = 10279] [serial = 44] [outer = 0] [url = about:blank]
[task 2023-10-30T23:53:48.391Z] 23:53:48     INFO - GECKO(10069) | [Child 10279: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 22 (7f4d97aedc00) [pid = 10279] [serial = 47] [outer = 0] [url = about:blank]
[task 2023-10-30T23:53:48.686Z] 23:53:48     INFO - TEST-PASS | browser/components/shopping/tests/browser/browser_shopping_onboarding.js | message is hidden - true == true - 

Comment 13

[Iulian Moraru]

Hi Negin! Can you please take another look at this?
Thank you!

Comment 14

[Negin Sauermann]

Sorry, this fell off my radar! Re-prioritizing this, didn't catch the uptick in intermittent.

Comment 15

[Negin Sauermann]

Removing accidental iteration so this can be correctly triaged.

Comment 16

[Negin Sauermann]

Attachment: Bug 1853979 - Disable events check on linux for browser_shopping_onboarding intermittent test failure

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec1ae79c6832
Disable events check on linux for browser_shopping_onboarding intermittent test failure r=aminomancer,perry.mcmanis

Comment 18

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ec1ae79c6832

Comment 19

[Intermittent Failures Robot]

17 failures in 573 pushes (0.03 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 7
• mozilla-beta: 8
• mozilla-central: 1
• try: 1

Platform and build breakdown:

• linux1804-64-asan-qr: 6
  • opt: 6
• linux1804-64-qr: 9
  • debug: 9
• macosx1015-64-qr: 1
  • debug: 1
• linux1804-64-tsan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1853979&startday=2023-10-31&endday=2023-10-31&tree=all

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nsauermann, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox120 to wontfix.

For more information, please visit BugBot documentation.

Comment 21

[Negin Sauermann]

Comment on attachment 9361292 [details]
Bug 1853979 - Disable events check on linux for browser_shopping_onboarding intermittent test failure

Beta/Release Uplift Approval Request

• User impact if declined: No user impact, simply skips a flakey test on all Linux builds versus TSAN only.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: N/A
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's not user facing and it's a browser test file change disabling the test for linux builds.
• String changes made/needed: N/A
• Is Android affected?: No

Comment 22

[Dianna Smith [:diannaS]]

Comment on attachment 9361292 [details]
Bug 1853979 - Disable events check on linux for browser_shopping_onboarding intermittent test failure

Approved for 120.0b6

Comment 23

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/661ffaa432e4

Comment 24

[Intermittent Failures Robot]

32 failures in 3356 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-beta: 15
• autoland: 12
• mozilla-central: 3
• try: 2

Platform and build breakdown:

• linux1804-64-qr: 15
  • debug: 15
• linux1804-64-asan-qr: 14
  • opt: 14
• windows11-64-2009-qr: 1
  • debug: 1
• macosx1015-64-qr: 1
  • debug: 1
• linux1804-64-tsan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1853979&startday=2023-10-30&endday=2023-11-05&tree=all