1851061 - Handle the case where screenshots is active when a tab gets moved to a different browser window

Status: RESOLVED DUPLICATE of bug 1873947

(Firefox :: Screenshots, defect, P2)

Description

[Sam Foster [:sfoster] (he/him)]

Right now, depending on what phase of the screenshots UI flow you are in, its possible to crash the browser by dragging a tab from one browser window to another.

One non-exhaustive STR:

1. Open 2 browser windows side by side
2. In window A, open the screenshots UI via ctrl+shift+s (or the toolbar button or context menu).
3. Click on "Save visible page" to get the preview dialog
4. Drag this tab from window A to window B.
5. (optional) Use ctrl+shift+s again to cancel and re-start the screenshot UI flow

ER:

• I think we'd expect the screenshot flow to be aborted and the preview dialog dismissed, such that we can start again

AR:

• The preview dialog goes away, but attempting to re-enter the screenshot UI causes a "Firefox is not responding, force quit?" prompt.

This is clearly a bad outcome, but also an unlikely STR so I'm setting severity a S3 for now. I think we should block on it though.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Tip From :mossop that might help here:

The TabClose event will have an adoptedBy property in its detail which is the tab in the new window.

I don't think we currently listen for TabClose at all. Maybe just ensuring we cancel & exit on close will fix this. Seems like preserving state so you can complete an in-progress screenshot after moving a tab to a different browser window is a stretch goal at best, and probably not even something we should support.

Comment 2

[Sam Foster [:sfoster] (he/him)]

We're working on this in bug 1873947.