1873947 - Screenshots get broken when dragging the tab to a new window

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect, P1)

Description

[Simona Badau, Desktop QA]

Attachment: Screen Recording with the issue

Found in

• Nightly 123.0a1

Affected versions

• Nightly 123.0a1

Tested platforms

• Affected platforms: macOS 13, Ubuntu 22.04 and Windows 10 x64.

Preconditions

• 'screenshots.browser.component.enabled' is set to true in about:config.

Steps to reproduce

1. Navigate to any website.
2. Enable Enable Screenshots by hitting the Cmd/Ctrl+Shift+S keys.
3. Drag the tab to create a new window.

Expected result

• A second window is created, and Screenshots should remain enabled.

Actual result

• The Screenshots overlay follows the tab in the second window while the buttons remain in the first window. Please see the screen recording for more details.

Regression range
This is not a regression, it's reproducible only when enabling the component version of Screenshots.

Additional notes

• The issue does not occur when 'screenshots.browser.component.enabled' is set to false in about:config.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:sbadau, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1873947 - Fix dragging screenshots tab to new window. r=sfoster,mconley

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/395699555a9d
Fix dragging screenshots tab to new window. r=sfoster,mconley

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/395699555a9d

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 7

[Negritas Sergiu, Desktop QA]

Hello! I can confirm that the issue is fixed with firefox 125.01(2024-03-08) on Windows 11, Ubuntu 22.04 and MacOS 12.6. I will update the flags and the status of this issue .

Have a nice day!