Closed
Bug 1851079
Opened 1 years ago
Closed 1 year ago
Refactor Activity.setAsImmersive to allow proper unit testing
Categories
(Fenix :: General, task)
Tracking
(firefox120 fixed)
RESOLVED
FIXED
120 Branch
| Tracking | Status | |
|---|---|---|
| firefox120 | --- | fixed |
People
(Reporter: mavduevskiy, Assigned: mavduevskiy)
References
Details
Attachments
(1 file)
Historically, the function used to set flags to the window, to set the fullscreen mode. Later on, the implementation was changed to make use of WindowInsetsControllerCompat. But not the name of the function nor the tests were adjusted to accommodate the change. Ideally, we want to verify that calls on the insetsController object were made.
|
Assignee | |
Updated•1 years ago
|
Assignee: nobody → mavduevskiy
|
||
Comment 1•1 years ago
|
||
Set release status flags based on info from the regressing bug 1849009
status-firefox117:
--- → unaffected
status-firefox118:
--- → unaffected
status-firefox119:
--- → affected
|
||
Comment 2•1 years ago
|
||
This isn't a regression, it's a refactor task. Move the bug into the 'see also' list.
Type: defect → task
status-firefox117:
unaffected → ---
status-firefox118:
unaffected → ---
status-firefox119:
affected → ---
Keywords: regression
No longer regressed by: 1849009
See Also: → 1849009
|
||
Comment 3•1 years ago
|
||
|
|
||
Comment 4•1 year ago
|
||
Authored by mike a
https://github.com/mozilla-mobile/firefox-android/commit/f1bb3f9a0f2c16dff16f041853e0a5ad8088829b
[main] Bug 1851079 – refactored Activity enterImmersiveMode to enable proper unit testing
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox120:
--- → fixed
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
|
||
Updated•1 year ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•