1849009 - full screen video doesn't extend into the notch area

Status: VERIFIED FIXED

(Fenix :: General, defect)

Description

[Mike a [:mavduevskiy]]

Steps to reproduce

1. Play a really wide video (e.x. https://www.youtube.com/watch?v=qIw6NuwmD_w)
2. Enter full screen.

Expected behavior

Take the full screen completely or be centered horizontally including the notch area.

Actual behavior

The notch area is blacked out or the video is shifter away from the notch and not positioned in the center.

Device information

• Firefox version:
  116, 117, 118
• Android device model:
  pixel 7
• Android OS version:
  Android 13

Any additional information?

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1849009 – extended fullscreen mode to utilize the notch area (#3298)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jonalmeida, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[BMO Github Automation]

Authored by mike a
https://github.com/mozilla-mobile/firefox-android/commit/1a1e89449bbeca0a701ea3722436d675f2e896e4
[main] Bug 1849009 – extended fullscreen mode to utilize the notch area

Comment 5

[Lorand Janos]

This issue is still reproducible on the latest Nightly build (119.0a1 from 2023-09-01).
Using the link from the steps, the notch area is still blacked out, however, the video is positioned in the center.
Device used: Google Pixel 7 (Android 14).
Reopening and removing the qe-verify label

Comment 6

[Lorand Janos]

Attachment: Screenshot_20230901-095832.png

Comment 7

[Mike a [:mavduevskiy]]

Hi, Lorand! The behaviour that you mentioned is exactly what we want. When the video is narrower than screen, it should be centered horizontally including notch area. And if it fits the width of the screen perfectly, it will be drawn under the notch (but I couldn't find a video like that for pixel 7, I have the same devices as you)

The first screenshot has the video shifted to the right. The black space on the left is the notch area, that system has reserved for it and doesn't alow the app to draw anything there. So, the fact that video on your screenshot is positioned perfectly centered between the top and botton of the screen is telling that the system is alowing the app to utilize the notch area.

I should have done a better job explaining it in the bug description, sorry for making you revisit it.

Comment 8

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1849009 – extended fullscreen mode to utilize the notch area (backport #3298) (#3637)

Comment 9

[Lorand Janos]

Hey, Mike! Yes, you are right, and though I didn't find a video to prove that either, I did find proof of it being extended to the notch area. The progress line. It begins in the notch area, unlike the on Nightly versions previous to this fix or even on Chrome.
Thank you for bringing this into my attention.
Attaching the screenshot, closing and marking the ticket as verified.

Comment 10

[Lorand Janos]

Attachment: Screenshot_20230914-075028.png

Comment 11

[Mike a [:mavduevskiy]]

Comment on attachment 9353037 [details] [review]
[mozilla-mobile/firefox-android] Bug 1849009 – extended fullscreen mode to utilize the notch area (backport #3298) (#3637)

Beta/Release Uplift Approval Request

• User impact if declined: Watching fullscreen videos won't utilize the notch area of the phone
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): the patch only sets notch related window flags for android api 28+
• String changes made/needed:
• Is Android affected?: Yes

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 9353037 [details] [review]
[mozilla-mobile/firefox-android] Bug 1849009 – extended fullscreen mode to utilize the notch area (backport #3298) (#3637)

Approved for 118.0b9 (last beta)  thanks.

Comment 13

[BMO Github Automation]

Authored by mike a
https://github.com/mozilla-mobile/firefox-android/commit/3ac96fc114ae3e60245693829b80ea911ac85263
[releases_v118] Bug 1849009 – extended fullscreen mode to utilize the notch area

Authored by https://github.com/pascalchevrel
https://github.com/mozilla-mobile/firefox-android/commit/f7abef80819567884939cf0ddbb3112bb3a03533
[releases_v118] Merge pull request #3637 from mozilla-mobile/mergify/bp/releases_v118/pr-3298

Comment 14

[Lorand Janos]

Verified as fixed on the latest Beta as well (118.0b9).
Device used: Google Pixel 7 (Android 14).
Marking the ticket as verified for 118 also.

Comment 15

[Lorand Janos]

Attachment: Screenshot_20230915-105100.png