Closed Bug 1851203 Opened 1 years ago Closed 1 year ago

Consider reading ad feature flag passed from sidebar child actor and shopping-container, rather than reading RPMBoolPref directly in settings.mjs

Categories

(Firefox :: Shopping, task, P3)

Product:
Firefox
Component:
Shopping
Type:
task

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: kpatenio, Unassigned)

References

Details

(Whiteboard: [fidefe-shopping])

This is a follow-up to Bug 1840520.

We pass the pref browser.shopping.experience2023.ads.enabled from the sidebar child actor to shopping-container.mjs. However, we don't pass it from shopping-container.mjs to settings.mjs. Currently, we read the pref in the settings component via a RPMGetBoolPref. We could just simply read this pref passed from shopping-container, but it requires some refactoring, even for the tests. For context, see this phabricator comment.

Severity: -- → N/A
Priority: -- → P4
Whiteboard: [fidefe-shopping]
Priority: P4 → P3
Summary: Consider reading ad feature flag passed from sidebar child actor, rather than reading RPMBoolPref directly in settings.mjs → Consider reading ad feature flag passed from sidebar child actor and shopping-container, rather than reading RPMBoolPref directly in settings.mjs

This refactor will be made in Bug 1851246. Keeping this ticket until that bug is marked as fixed.

Depends on: 1851246
Flags: needinfo?(kpatenio)

Marking as FIXED since Bug 1851246 landed.

Status: NEW → RESOLVED
Closed: 1 year ago
Flags: needinfo?(kpatenio)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.