1851327 - Reader view font type controls (Sans/Serif) do not follow Firefox settings

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, defect, P3)

Description

[Thaddee Tyl [:espadrine]]

Reproductible steps:

1. Go to about:preferences, search for "font", click on "advanced".
2. Set the Sans Serif font to Atkinson Hyperlegible, click OK.
3. Go to https://espadrine.github.io/blog/posts/mean-range-of-bell-curve-distributions.html
4. Click on the Reader View button at the right of the address bar.
5. On the left, click "Type controls", and select Sans-serif.
6. Right-click on the text of the article; click "inspect"; click "Fonts".

What occurs:
The font “Nimbus Sans” is indicated as in use by Reader View.

What should occur:
The font Atkinson Hyperlegible should be indicated as in use.

Additional system information:

• OS: KDE Neon 5.27 Ubuntu 22.04
• Both Atkinson Hyperlegible and Nimbus Sans are installed.
• CPU: Intel(R) Core(TM) i5-8350U CPU

Comment 1

[kotatsuyaki]

I worked around this problem by adding the following rules to chrome/userContent.css under the profile directory (which requires toolkit.legacyUserProfileCustomizations.stylesheets set to 1). Tested on Firefox 117.0.

.serif .moz-reader-content {
    font-family: serif;
}

.sans-serif .moz-reader-content {
    font-family: sans-serif;
}

Comment 2

[Sergei Smagin]

Attachment: Bug 1851327 - Respect font settings in Reader Mode

Use serif, sans-serif and monospace instead of, respectively,

Georgia, "Times New Roman", serif
Helvetica, Arial, sans-serif
"Courier New", Courier, monospace

This allows browser to actually use fonts set in the font settings.

Comment 3

[Sergei Smagin]

Attachment: Bug 1851327 - Respect font settings in Reader mode

Use serif, sans-serif and monospace instead of, respectively,

Georgia, "Times New Roman", serif
Helvetica, Arial, sans-serif
"Courier New", Courier, monospace

This allows browser to actually use fonts set in the font settings.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc9cb1d32e78
Respect font settings in Reader mode r=reader-mode-reviewers,desktop-theme-reviewers,Gijs

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_readerMode_textLayoutPref.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/2d56061eb886ad6c984764932d011258fb6e8ba3

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/components/reader/tests/browser/browser_readerMode_textLayoutPref.js | "monospace" == ""Courier New", Courier, monospace" - got "monospace", expected ""Courier New", Courier, monospace" (operator ==)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8f04d489a4b
Respect font settings in Reader mode r=reader-mode-reviewers,desktop-theme-reviewers,Gijs,emilio

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_readerMode_textLayoutPref.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/b74bc552f04618071d20df9e058932960271ceb6

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/components/reader/tests/browser/browser_readerMode_textLayoutPref.js | "sans-serif" == "Helvetica, Arial, sans-serif" - got "sans-serif", expected "Helvetica, Arial, sans-serif" (operator ==)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1355c8ac3d4c
Respect font settings in Reader mode r=reader-mode-reviewers,desktop-theme-reviewers,Gijs,emilio

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1355c8ac3d4c

Comment 10

[Gérard Talbot]

This bug has unfortunately not been fixed for the Firefox 128.n ESR series.