1851563 - Can't open more than 19 emails with enter key

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Greg Skyles]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36

Steps to reproduce:

1. In a folder with more than 19 messages, click to select the top message, then shift-click a message 20 or more below that. At the top of the window, it should say:
   <folder name> xxx Messages yy Selected, where yy is >= 20
2. Press the Enter key to open the selected messages.

I am using TB 115.2.0 (64 bit) on Windows 11 Pro 22H2

Actual results:

Nothing. The messages remain selected, no messages are opened.

If the selection contains 19 or fewer messages, they open in their respective tabs.

Expected results:

The selected messages should open, or a message should appear stating that the messages cannot be opened for some reason.

On another machine, I have TB 102.15.0 (32-bit) on Windows 10 Pro 22H2. Here what happens is that a (relatively useless) window pops up stating something to the effect that it could take some time to open more than 20 messages and do I want to continue or not. Electing to continue allows the selected message to open.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

When reproducing this. console shows

Uncaught Error: ChromeUtils.import is called against an ES module script (resource:///modules/PluralForm.sys.mjs).  Please use ChromeUtils.importESModule instead (SyntaxError: export declarations may only appear at top level of a module)
    confirmAction resource:///modules/MailUtils.jsm:163
    displayMessages resource:///modules/MailUtils.jsm:229
    cmd_openMessage chrome://messenger/content/mailCommon.js:105
    doCommand chrome://messenger/content/mailCommon.js:705
    _onItemActivate chrome://messenger/content/about3Pane.js:4367
    _onKeyPress chrome://messenger/content/about3Pane.js:4335
    handleEvent chrome://messenger/content/about3Pane.js:4265
MailUtils.jsm:163:21

Seems to be a regression, following patch seems to fix it.

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1851563 - Fix import of PluralForm.sys.mjs. r=standard8

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/40588c683f49
Fix import of PluralForm.sys.mjs. r=freaktechnik

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9351554 [details]
Bug 1851563 - Fix import of PluralForm.sys.mjs. r=standard8

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 118.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/f01f50ac14c4

Comment 6

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9351554 [details]
Bug 1851563 - Fix import of PluralForm.sys.mjs. r=standard8

[Approval Request Comment]
Regression caused by (bug #): 1696777
User impact if declined: Can't open more than 19 emails with enter key
Testing completed (on c-c, etc.): currently on beta
Risk to taking this patch (and alternatives if risky): none

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9351554 [details]
Bug 1851563 - Fix import of PluralForm.sys.mjs. r=standard8

[Triage Comment]
Approved for esr115

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 115.2.3:
https://hg.mozilla.org/releases/comm-esr115/rev/b82e5028a7e7