185160 - [gtk2] crashes due to uninitialized mDrawingarea

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Robin Lu]

There are two crashes due to uninitialized mDrawingarea here. Besides the
printing problem, there are:
- crash when close a tab when the webpage is loading and that webpage needs plugin
1 . at least  two opened tabs in content area.
2 . one tab is loading a webpage(the icon of this tab is two rolling arrows)
3 . this webpage content needs a kind plugin but the mozilla didn't install
4 . click right button on tab and select the "close the tab" item in the popup menu.
result:mozilla crashed .
crashes at:
in nsWindow.cpp : 710

GtkWidget *widget =
            get_gtk_widget_for_gdk_window(mDrawingarea->inner_window);

mDrawingarea is null.

-  crash at tinderbox
1. open tinderbox http://tinderbox.mozilla.org/showbuilds.cgi?tree=SeaMonkey
2. In the tree status table, click any name in the Guilty Column
3. before the tip being shown up, click elsewhere to forbid the tip's shown
result: mozilla crashes
You may need some patience to reproduce this bug.
crashes at:
void*
nsWindow::GetNativeData(PRUint32 aDataType)
{
    switch (aDataType) {
    case NS_NATIVE_WINDOW:
    case NS_NATIVE_WIDGET:
        return mDrawingarea->inner_window;
mDrawingarea is null.

Comment 1

[Robin Lu]

Attachment: patch

It's an easy patch, just checking the pointers before any action. At least,
it's no harm.

Comment 2

[Christopher Blizzard (:blizzard)]

Attachment: patch

This patch cleans up a lot of bogus style, removes the check in NativeCreate()
and removes the extra initialization of mIsTopLevel since that's done in the
common widget code.

Comment 3

[Christopher Blizzard (:blizzard)]

Checked in.  Thanks!