1851629 - Consider using an attribute like `isAnalysisInProgress` to conditionally render message when an analysis is in-progress

Status: RESOLVED FIXED

(Firefox :: Shopping, task, P1)

Description

[kpatenio]

We heard that the API may contain some information to help us identify if an analysis (for given a product page) is in-progress. We can use it to simplify how we render the analysis-in-progress message-bar, compared to our current implementation.

Comment 1

[Fred Chasen [:fchasen]]

Attachment: Bug 1851629 - Add isAnalysisInProgress to Shopping Container. r=#shopping-reviewers,kpatenio

This is only part 1 for Bug 1851629, but it sets isAnalysisInProgress from the ShoppingSidebarChild and shows the analysis-in-progress message bar is that is true and there isn't data.

Comment 2

[kpatenio]

Fred has a patch up, so reassigning to him.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa4e3903740d
Add isAnalysisInProgress to Shopping Container. r=shopping-reviewers,kpatenio

Comment 4

[Iulian Moraru]

Backed out for causing bc failures on browser_shopping_survey.js.

• Push with failures

• Failure log

• Backout link

[task 2023-09-16T01:04:08.243Z] 01:04:08     INFO - TEST-PASS | browser/components/shopping/tests/browser/browser_shopping_survey.js | Survey is Enabled - true == true - 
[task 2023-09-16T01:04:08.244Z] 01:04:08     INFO - Buffered messages finished
[task 2023-09-16T01:04:08.244Z] 01:04:08     INFO - TEST-UNEXPECTED-FAIL | browser/components/shopping/tests/browser/browser_shopping_survey.js | Uncaught exception in test bound test_showSurvey_Enabled - survey-screen - timed out after 50 tries.
[task 2023-09-16T01:04:08.245Z] 01:04:08     INFO - Leaving test bound test_showSurvey_Enabled
[task 2023-09-16T01:04:08.245Z] 01:04:08     INFO - Entering test bound test_showSurvey_Disabled
[task 2023-09-16T01:04:08.246Z] 01:04:08     INFO - GECKO(17395) | [Child 17600: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f0add012800 == 3 [pid = 17600] [id = 19]
[task 2023-09-16T01:04:08.246Z] 01:04:08     INFO - GECKO(17395) | [Child 17600: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 14 (7f0add04f020) [pid = 17600] [serial = 58] [outer = 0]
[task 2023-09-16T01:04:08.247Z] 01:04:08     INFO - GECKO(17395) | [Child 17600: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 15 (7f0add013800) [pid = 17600] [serial = 59] [outer = 7f0add04f020]
[task 2023-09-16T01:04:08.248Z] 01:04:08     INFO - GECKO(17395) | [Child 17600: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 16 (7f0add373000) [pid = 17600] [serial = 60] [outer = 7f0add04f020]
[task 2023-09-16T01:04:08.484Z] 01:04:08     INFO - TEST-PASS | browser/components/shopping/tests/browser/browser_shopping_survey.js | Survey is disabled - true == true - 

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f35d640b627
Add isAnalysisInProgress to Shopping Container. r=shopping-reviewers,kpatenio

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0f35d640b627