1852836 - Sidebar goes back to loading state if closed and then re-opened

Status: VERIFIED FIXED

(Firefox :: Shopping, defect, P1)

Description

[kpatenio]

Attachment: hide_show_loading_sidebar.mov

STR:

1. Load a valid product page. Example
2. Make sure sidebar is open and there is data
3. Press the shopping URLbar icon to close the sidebar
4. Re-open again using the URLbar icon

Expected: data should be visible on the sidebar after opening the sidebar
Actual: data is stuck in loading state. Refresh is needed to show analysis on sidebar

Notes:

• Also does not work if the sidebar is hidden already when viewing a new product page and then reopening the sidebar

Regression log:

• https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7ddcc5c570857b59a8ca28d15053b56adee3751a&tochange=b2453b43eee06d8a6ec112c23a639dbdafffe9d5

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1852099

:fchasen, since you are the author of the regressor, bug 1852099, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Donal Meehan [:dmeehan|PTO Sept 22-Oct 3]]

Tracing this since it was triaged as S2

Comment 3

[Fred Chasen [:fchasen]]

Attachment: Bug 1852836 - Update shopping URI equality check r=#shopping-reviewers

Moves the product URI equality checks to isSameProduct(newURI, currentURI) method to simplify the flow and add checks for null URIs or products.

Fix the Product uninit method to set all properties to undefined.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d905e97b6c0e
Update shopping URI equality check r=shopping-reviewers,jhirsch

Comment 5

[Sandor Molnar]

https://hg.mozilla.org/mozilla-central/rev/d905e97b6c0e

Comment 6

[Peter Magyari (Desktop QA)]

I have verified the fix using Nightly 119.0a1(20230915043542) on MacOS 11, Windows 10 and Ubuntu 20.04.
The sidebar is populated with the proper data in about 1s after re-opening.