1851780 - Maximizing the window, makes the browser chrome disappear

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P3)

Description

[Nicole Weber [:topotropic]]

Attachment: Firefox Nightly, toolbar on hover

when I click on the green circle in Mac OS to maximize the Firefox Nightly window, it goes all the way fullscreen so that I only see webcontent and the browser chrome is hidden and I can't open a new tab or see my tabs; when I hover, I sometimes see just the app bar but not the Firefox UI, see screenshot

Comment 1

[Brad Werth [:bradwerth]]

I'm not able to reproduce. Is there a specific state the window needs to be in before triggering this problem?

Very likely the regression will be Bug 1802193, which flipped the pref to use native fullscreen on Nightly.

Comment 2

[Donal Meehan [:dmeehan]]

Removing tracking and regression-window wanted

Comment 3

[Brad Werth [:bradwerth]]

Aha! With the pref browser.fullscreen.autohide I can sometimes get the chrome to disappear in fullscreen when moving the mouse cursor up to the menubar and back down again. In fact, with that pref set, I can get the chrome to appear if and only if I move the cursor to the very top-most pixel below the menubar. If I move it to that pixel, the chrome will first appear (with no titlebar) and then if I move one pixel further, the titlebar will appear. If I instead move the cursor rapidly to the menubar, I get the titlebar but no chrome.

This needs to be fixed so Firefox behaves in a consistent fashion.

Comment 4

[Brad Werth [:bradwerth]]

Attachment: Bug 1851780: Make macOS menubar appearance force appearance of nav toolbox.

Prior to this patch, users with the pref browser.fullscreen.autohide set
had to hit a 1-pixel tall element to get the tab bar to appear. If they miss
this shallow element, the macOS menubar will animate down, covering the
target, and it won't be possible to make the tab bar to appear until the
menubar is animated away again.

This patch ensures that any time the macOS menubar is animated down, we also
show the tab bar.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/149195ba0e44
Make macOS menubar appearance force appearance of nav toolbox. r=edgar

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/149195ba0e44