1863134 - Regression: macOS browser chrome disappears on hover in fullscreen and with autohidden toolbar

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P3)

Description

[dropboxm1]

Steps to reproduce:

Regression, see bugs 1850279, 1851780, and the patch https://hg.mozilla.org/integration/autoland/rev/149195ba0e44 ,
"Make macOS menubar appearance force appearance of nav toolbox. r=edgar" .

On macOS, any version >=119.0.

1. Start Firefox.
2. Set fullscreen.autohide pref to True, or right-click on browser chrome/any open tab heading in fullscreen and select 'Hide toolbars'.
3. Move cursor to top of screen.

Actual results:

Browser menubar and chrome both appear when scrolling up to top of screen. When scrolling back down past menubar, chrome disappears with it. Impossible to interact with any browser tabs as a result, until exiting fullscreen.

It is possible for chrome without menubar to appear, if moving mouse very slowly to top of screen (1-pixel region).

Expected results:

Browser menubar disappears but chrome doesn't disappear when scrolling down.
Or, merge the 2 bars, see open bug 1707061.

Likely the culprit is line 1.24 in the patch https://hg.mozilla.org/mozilla-central/rev/149195ba0e44, since the code's comment intends for firefox to animate away the toolbox when hiding the menubar.

Comment 1

[dropboxm1]

Attachment: Screen recording showing bug.

Comment 2

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Cocoa' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1851780

Comment 4

[Brad Werth [:bradwerth]]

I'll figure this out.

Comment 5

[Brad Werth [:bradwerth]]

Attachment: Bug 1863134: Stop hiding the nav toolbox when the menubar is animated away.

This was done erroneously in an earlier code fix that was trying to fix
the showing and hiding of the menubar. It is not necessary to hide the
nav toolbox when the menubar is animated away. The nav toolbox will be
hidden when the user moves the cursor out of the nav toolbox area.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7253e1da3163
Stop hiding the nav toolbox when the menubar is animated away. r=edgar

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7253e1da3163

Comment 8

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:bradwerth, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox120 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Brad Werth [:bradwerth]]

It can ride the trains.

Comment 11

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 31 Aug- 11 Sep, please ni? :mboldan]]

Reproduced the issue with Firefox 120.0.1 on macOS 12. After activating the 'Hide toolbars' option and entering fullscreen the tab bar can no longer be selected.
The issue is verified fixed with Firefox 121.0 on macOS 12. The tab bar and URL bar can be properly selected after following STR from comment 0.